You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "wangsheng (Code Review)" <ge...@cloudera.org> on 2020/01/19 11:32:52 UTC

[Impala-ASF-CR] IMPALA-9287: Fixed the error of running test kudu table create without hms after setting USE CDP HIVE=true 

wangsheng has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15057


Change subject: IMPALA-9287: Fixed the error of running test_kudu_table_create_without_hms after setting USE_CDP_HIVE=true
......................................................................

IMPALA-9287: Fixed the error of running
test_kudu_table_create_without_hms after setting USE_CDP_HIVE=true

Tests:
  * Ran test_kudu_table_create_without_hms.py by setting
  USE_CDP_HIVE=true locally

Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
---
M fe/pom.xml
1 file changed, 73 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/15057/3
-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 3
Gerrit-Owner: wangsheng <sk...@163.com>

[Impala-ASF-CR] IMPALA-9287: Fix test kudu table create without hms in Hive3

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Fix test_kudu_table_create_without_hms in Hive3
......................................................................


Patch Set 10:

(1 comment)

I ran a test with USE_CDP_HIVE=true and it passed: https://jenkins.impala.io/job/ubuntu-16.04-from-scratch-cdp-hive/60/

I think we just need to make sure the addition in pom files is minimal.

http://gerrit.cloudera.org:8080/#/c/15057/9/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/15057/9/bin/bootstrap_system.sh@315
PS9, Line 315: 500
> Not 1500, but 500. 's/\(max_connections = \)\S*/\1500/g' this usage means: 
Cool! Thanks for sharing!



-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 10
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Thu, 06 Feb 2020 02:17:16 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
......................................................................


Patch Set 13: Code-Review+2

Thanks for seeing the patch through. Looks good to me.


-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 13
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Wed, 12 Feb 2020 18:02:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
......................................................................


Patch Set 12:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15057/12/shaded-deps/pom.xml
File shaded-deps/pom.xml:

http://gerrit.cloudera.org:8080/#/c/15057/12/shaded-deps/pom.xml@99
PS12, Line 99:                 <!-- IMPALA-9287: Needed when catalogd used embedded HMS-->
See my comment earlier on PartitionExpressionProxy configurations. I think these are not necessary if we change the default configuration values for metastore.



-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 12
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Mon, 10 Feb 2020 18:46:37 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9287: Fixed the error of running test kudu table create without hms after setting USE CDP HIVE=true

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Fixed the error of running test_kudu_table_create_without_hms after setting USE_CDP_HIVE=true
......................................................................


Patch Set 5:

(1 comment)

I'm not sure whether we should introduce these dependencies. Vihang worked on the integration of Hive-3. He may know more about this.

http://gerrit.cloudera.org:8080/#/c/15057/5/fe/pom.xml
File fe/pom.xml:

http://gerrit.cloudera.org:8080/#/c/15057/5/fe/pom.xml@1111
PS5, Line 1111:         <dependency>
              :           <groupId>org.apache.impala</groupId>
              :           <artifactId>impala-minimal-hive-exec</artifactId>
              :           <version>${project.version}</version>
              :         </dependency>
We used a shaded version of hive-exec here. Defined in shaded-deps/pom.xml.



-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 5
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Mon, 20 Jan 2020 15:02:33 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9287: Fixed the error of running test kudu table create without hms after setting USE CDP HIVE=true

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Fixed the error of running test_kudu_table_create_without_hms after setting USE_CDP_HIVE=true
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15057/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15057/6//COMMIT_MSG@7
PS6, Line 7: Fixed the error of running
           : test_kudu_table_create_without_hms after setting USE_CDP_HIVE=true
The title can be shorter: "Fix test_kudu_table_create_without_hms in Hive3"


http://gerrit.cloudera.org:8080/#/c/15057/6//COMMIT_MSG@12
PS6, Line 12: The solution is to add related maven
            : dependency in $IMPALA_HOME/fe/pom.xml.
Need to update the commit message too.



-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 6
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Tue, 21 Jan 2020 03:19:37 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9287: Fixed the error of running test kudu table create without hms after setting USE CDP HIVE=true

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Fixed the error of running test_kudu_table_create_without_hms after setting USE_CDP_HIVE=true
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15057/5/fe/pom.xml
File fe/pom.xml:

http://gerrit.cloudera.org:8080/#/c/15057/5/fe/pom.xml@1231
PS5, Line 1231:           <groupId>org.apache.hive</groupId>
Adding hive-exec dependency is not recommended since it will bring along with it a whole lot of other unrelated dependencies. Can you specify what is the exact error message this is trying to fix?



-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 5
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Tue, 21 Jan 2020 02:55:54 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
......................................................................


Patch Set 13:

(3 comments)

> (2 comments)
 > 
 > > > (1 comment)
 > >
 > > The error is: cannot found class PartitionExpressionForMetastore.
 > I
 > > add class one by one to keep pom files minimal, all including
 > four
 > > classed.
 > 
 > Ah I see. I think this can be fixed by setting metastore.expression.proxy
 > to org.apache.hadoop.hive.metastore.DefaultPartitionExpressionProxy
 > in the hive-site.xml.py if hive_major_version >=3 here:
 > https://github.com/apache/impala/blob/master/fe/src/test/resources/hive-site.xml.py#L93
 > 
 > The PartitionExpressionProxy API is only usable by Hive since it
 > uses some of its internal classes which are unavailable to non-hive
 > applications. Refer https://cwiki.apache.org/confluence/display/Hive/AdminManual+Metastore+3.0+Administration
 > standalone mode for more details.

Thanks for your code view patiently, Vihang. I've already modified code according to your advice.

http://gerrit.cloudera.org:8080/#/c/15057/12/fe/pom.xml
File fe/pom.xml:

http://gerrit.cloudera.org:8080/#/c/15057/12/fe/pom.xml@1065
PS12, Line 1065:           <exclusions>
> I would avoid making any changes to hive-2 profile since they seem unnecess
Done


http://gerrit.cloudera.org:8080/#/c/15057/12/fe/pom.xml@1235
PS12, Line 1235:           <scope>runtime</scope>
> This dependency can be changed to a runtime scope here for hive-3 profile o
Done


http://gerrit.cloudera.org:8080/#/c/15057/12/shaded-deps/pom.xml
File shaded-deps/pom.xml:

http://gerrit.cloudera.org:8080/#/c/15057/12/shaded-deps/pom.xml@99
PS12, Line 99:               </includes>
> See my comment earlier on PartitionExpressionProxy configurations. I think 
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 13
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Tue, 11 Feb 2020 02:48:08 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9287: Fix test kudu table create without hms in Hive3

Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Fix test_kudu_table_create_without_hms in Hive3
......................................................................


Patch Set 8:

(2 comments)

> (2 comments)

All done

http://gerrit.cloudera.org:8080/#/c/15057/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15057/6//COMMIT_MSG@7
PS6, Line 7: Fix test_kudu_table_create_without_hms in Hive3
           : 
> The title can be shorter: "Fix test_kudu_table_create_without_hms in Hive3"
Done


http://gerrit.cloudera.org:8080/#/c/15057/6//COMMIT_MSG@12
PS6, Line 12: E/fe/pom.xml and
            : $IMPALA_HOME/shaded-deps/pom.xml.
> Need to update the commit message too.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 8
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Tue, 21 Jan 2020 03:24:31 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9287: Fix test kudu table create without hms in Hive3

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Fix test_kudu_table_create_without_hms in Hive3
......................................................................


Patch Set 9:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15057/9/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/15057/9/bin/bootstrap_system.sh@315
PS9, Line 315: 500
nit: 1500


http://gerrit.cloudera.org:8080/#/c/15057/9/tests/custom_cluster/test_kudu_table_create_without_hms.py
File tests/custom_cluster/test_kudu_table_create_without_hms.py:

http://gerrit.cloudera.org:8080/#/c/15057/9/tests/custom_cluster/test_kudu_table_create_without_hms.py@32
PS9, Line 32:   @SkipIfHive3.without_hms_not_supported
This should be removed, otherwise the test is skipped when using Hive3.



-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 9
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Tue, 04 Feb 2020 04:00:30 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
......................................................................


Patch Set 12:

> (1 comment)
 > 
 > I ran a test with USE_CDP_HIVE=true and it passed:
 > https://jenkins.impala.io/job/ubuntu-16.04-from-scratch-cdp-hive/60/
 > 
 > I think we just need to make sure the addition in pom files is
 > minimal.

Thanks for ran test, Quanlong. I've already reduce some unnecessary classes to keep pom files minimal.


-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 12
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Thu, 06 Feb 2020 08:52:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
......................................................................


Patch Set 12:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5137/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 12
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Thu, 06 Feb 2020 09:38:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
......................................................................


Patch Set 14: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 14
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Wed, 12 Feb 2020 18:02:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9287: Fix test kudu table create without hms in Hive3

Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Fix test_kudu_table_create_without_hms in Hive3
......................................................................


Patch Set 9:

> (1 comment)

Soory for my late reply, Quanlong. I've already ran this test case before submit patch, and result is passed. I checked my test environment, found that pg max_connections been changed to 1000(default is 100). So I modify max_connections in $IMPALA_HOME/bin/bootstrap_system.sh. You can test the latest code in your environment when you are free. Thanks for your review again.


-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 9
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Tue, 04 Feb 2020 03:56:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9287: Fixed the error of running test kudu table create without hms after setting USE CDP HIVE=true

Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Fixed the error of running test_kudu_table_create_without_hms after setting USE_CDP_HIVE=true
......................................................................


Patch Set 5:

1. Run this test case by setting USE_CDP_HIVE=true and rebuild impala, passed
2. Run exhaustive test on jenkins, here is the url: https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/9722/


-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 5
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Mon, 20 Jan 2020 01:47:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9287: Fixed the error of running test kudu table create without hms after setting USE CDP HIVE=true

Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Fixed the error of running test_kudu_table_create_without_hms after setting USE_CDP_HIVE=true
......................................................................

IMPALA-9287: Fixed the error of running
test_kudu_table_create_without_hms after setting USE_CDP_HIVE=true

When build impala after setting USE_CDP_HIVE=true, the custom cluster
test case test_kudu_table_create_without_hms would failed due to
lacking of related jars. The solution is to add related maven
dependency in $IMPALA_HOME/fe/pom.xml.

Tests:
  * Ran test_kudu_table_create_without_hms.py by setting
  USE_CDP_HIVE=true locally

Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
---
M fe/pom.xml
M shaded-deps/pom.xml
2 files changed, 25 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/15057/6
-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 6
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>

[Impala-ASF-CR] IMPALA-9287: Fixed the error of running test kudu table create without hms after setting USE CDP HIVE=true

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Fixed the error of running test_kudu_table_create_without_hms after setting USE_CDP_HIVE=true
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5465/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 3
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 19 Jan 2020 12:16:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9287: Fix test kudu table create without hms in Hive3

Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Fix test_kudu_table_create_without_hms in Hive3
......................................................................

IMPALA-9287: Fix test_kudu_table_create_without_hms in Hive3

When build impala after setting USE_CDP_HIVE=true, the custom cluster
test case test_kudu_table_create_without_hms would failed due to
lacking of related jars. The solution is to add related maven
dependency in $IMPALA_HOME/fe/pom.xml and
$IMPALA_HOME/shaded-deps/pom.xml.

Tests:
  * Ran test_kudu_table_create_without_hms.py by setting
  USE_CDP_HIVE=true locally

Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
---
M fe/pom.xml
M shaded-deps/pom.xml
2 files changed, 25 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/15057/8
-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 8
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>

[Impala-ASF-CR] IMPALA-9287: Fix test kudu table create without hms in Hive3

Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Fix test_kudu_table_create_without_hms in Hive3
......................................................................

IMPALA-9287: Fix test_kudu_table_create_without_hms in Hive3

When build impala after setting USE_CDP_HIVE=true, the custom cluster
test case test_kudu_table_create_without_hms would failed due to
lacking of related jars. The solution is to add related maven
dependency in $IMPALA_HOME/fe/pom.xml and
$IMPALA_HOME/shaded-deps/pom.xml.

Tests:
  * Ran test_kudu_table_create_without_hms.py by setting
  USE_CDP_HIVE=true locally

Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
---
M bin/bootstrap_system.sh
M fe/pom.xml
M shaded-deps/pom.xml
3 files changed, 31 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/15057/9
-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 9
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>

[Impala-ASF-CR] IMPALA-9287: Fix test kudu table create without hms in Hive3

Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Fix test_kudu_table_create_without_hms in Hive3
......................................................................

IMPALA-9287: Fix test_kudu_table_create_without_hms in Hive3

When build impala after setting USE_CDP_HIVE=true, the custom cluster
test case test_kudu_table_create_without_hms would failed due to
lacking of related jars. The solution is to add related maven
dependency in $IMPALA_HOME/fe/pom.xml and
$IMPALA_HOME/shaded-deps/pom.xml.

Tests:
  * Ran test_kudu_table_create_without_hms.py by setting
  USE_CDP_HIVE=true locally

Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
---
M bin/bootstrap_system.sh
M fe/pom.xml
M shaded-deps/pom.xml
M tests/custom_cluster/test_kudu_table_create_without_hms.py
4 files changed, 31 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/15057/10
-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 10
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>

[Impala-ASF-CR] IMPALA-9287: Fixed the error of running test kudu table create without hms after setting USE CDP HIVE=true

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Fixed the error of running test_kudu_table_create_without_hms after setting USE_CDP_HIVE=true
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5467/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 5
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 19 Jan 2020 12:24:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
......................................................................


Patch Set 13:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5195/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 13
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Tue, 11 Feb 2020 03:32:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9287: Fix test kudu table create without hms in Hive3

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Fix test_kudu_table_create_without_hms in Hive3
......................................................................


Patch Set 10:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/15057/10//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15057/10//COMMIT_MSG@7
PS10, Line 7: IMPALA-9287: Fix test_kudu_table_create_without_hms in Hive3
I suggest modify the title of the JIRA which is more appropriate. Something like "Add support for embedded HMS in CDP builds". Also, some additional details like why we are doing this in the commit message would be great.


http://gerrit.cloudera.org:8080/#/c/15057/10/fe/pom.xml
File fe/pom.xml:

http://gerrit.cloudera.org:8080/#/c/15057/10/fe/pom.xml@1210
PS10, Line 1210:         needs datanucleus as test dependency-->
Since we are removing the test scope this comment can be edited/removed.


http://gerrit.cloudera.org:8080/#/c/15057/10/fe/pom.xml@1214
PS10, Line 1214:           <version>3.2.0-m3</version>
please add a <scope>runtime</scope> here, along with the comment pointing to the JIRA


http://gerrit.cloudera.org:8080/#/c/15057/10/fe/pom.xml@1233
PS10, Line 1233:           <version>${hive.version}</version>
can you add <scope>runtime</scope> here? Also, please add a comment as to why we need this dependency (Eg. Some deployments use embedded HMS which needs this dependency) along with the JIRA number.



-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 10
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Thu, 06 Feb 2020 07:01:03 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9287: Fixed the error of running test kudu table create without hms after setting USE CDP HIVE=true

Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Fixed the error of running test_kudu_table_create_without_hms after setting USE_CDP_HIVE=true
......................................................................

IMPALA-9287: Fixed the error of running
test_kudu_table_create_without_hms after setting USE_CDP_HIVE=true

When build impala after setting USE_CDP_HIVE=true, the custom cluster
test case test_kudu_table_create_without_hms would failed due to
lacking of related jars. The solution is to add related maven
dependency in $IMPALA_HOME/fe/pom.xml.

Tests:
  * Ran test_kudu_table_create_without_hms.py by setting
  USE_CDP_HIVE=true locally

Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
---
M fe/pom.xml
1 file changed, 73 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/15057/5
-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 5
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
......................................................................


Patch Set 13:

> Patch Set 13:
> 
> Thanks for making the suggested change. I have triggered a job https://jenkins.impala.io/job/ubuntu-16.04-from-scratch-cdp-hive/62 which will run the core tests with the patch. Lets wait to for it to complete (takes about 3-4 hours). The patch looks good to me.

I rerun the job here and it passed: https://jenkins.impala.io/job/ubuntu-16.04-from-scratch-cdp-hive/63/


-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 13
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Tue, 11 Feb 2020 22:57:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9287: Fixed the error of running test kudu table create without hms after setting USE CDP HIVE=true

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Fixed the error of running test_kudu_table_create_without_hms after setting USE_CDP_HIVE=true
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5466/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 4
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 19 Jan 2020 12:17:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9287: Fixed the error of running test kudu table create without hms after setting USE CDP HIVE=true

Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Fixed the error of running test_kudu_table_create_without_hms after setting USE_CDP_HIVE=true
......................................................................

IMPALA-9287: Fixed the error of running
test_kudu_table_create_without_hms after setting USE_CDP_HIVE=true

Tests:
  * Ran test_kudu_table_create_without_hms.py by setting
  USE_CDP_HIVE=true locally

Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
---
M fe/pom.xml
1 file changed, 73 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/15057/4
-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 4
Gerrit-Owner: wangsheng <sk...@163.com>

[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
......................................................................


Patch Set 14: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 14
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Wed, 12 Feb 2020 22:54:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
......................................................................


Patch Set 14:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5326/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 14
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Wed, 12 Feb 2020 18:02:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9287: Fix test kudu table create without hms in Hive3

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Fix test_kudu_table_create_without_hms in Hive3
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15057/8//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15057/8//COMMIT_MSG@16
PS8, Line 16:   * Ran test_kudu_table_create_without_hms.py by setting
            :   USE_CDP_HIVE=true locally
Looks like the problem still exists. I attached the logs in the JIRA. Have you rebuilt Impala with USE_CDP_HIVE=true? I think the proper steps are:

* Shutdown the minicluster: bin/start-impala-cluster --kill && testdata/bin/kill-all.sh
* Open a new shell with empty environments
* export USE_CDP_HIVE=true
* source bin/impala-config.sh
* ./builall.sh -noclean -notests -format
* Then run test_kudu_table_create_without_hms.py



-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 8
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Tue, 21 Jan 2020 12:09:21 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
......................................................................

IMPALA-9287: Add support for embedded HMS in CDP builds

In some situations, an embedded HMS is enough for catalogd server.
And we've already implemented this in IMPALA-8974. But after
setting USE_CDP_HIVE=true and rebuilt impala, the custom cluster
test case test_kudu_table_create_without_hms would failed due to
lacking of related jars. The solution is to add related maven
dependency in $IMPALA_HOME/fe/pom.xml and
$IMPALA_HOME/shaded-deps/pom.xml.

Tests:
  * Ran test_kudu_table_create_without_hms.py by setting
  USE_CDP_HIVE=true locally

Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
---
M bin/bootstrap_system.sh
M fe/pom.xml
M fe/src/test/resources/hive-site.xml.py
M tests/custom_cluster/test_kudu_table_create_without_hms.py
4 files changed, 36 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/15057/13
-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 13
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>

[Impala-ASF-CR] IMPALA-9287: Fix test kudu table create without hms in Hive3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Fix test_kudu_table_create_without_hms in Hive3
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5471/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 6
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Tue, 21 Jan 2020 03:58:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9287: Fix test kudu table create without hms in Hive3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Fix test_kudu_table_create_without_hms in Hive3
......................................................................


Patch Set 8:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5472/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 8
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Tue, 21 Jan 2020 04:09:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
......................................................................

IMPALA-9287: Add support for embedded HMS in CDP builds

In some situations, an embedded HMS is enough for catalogd server.
And we've already implemented this in IMPALA-8974. But after
setting USE_CDP_HIVE=true and rebuilt impala, the custom cluster
test case test_kudu_table_create_without_hms would failed due to
lacking of related jars. The solution is to add related maven
dependency in $IMPALA_HOME/fe/pom.xml and
$IMPALA_HOME/shaded-deps/pom.xml.

Tests:
  * Ran test_kudu_table_create_without_hms.py by setting
  USE_CDP_HIVE=true locally

Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
---
M bin/bootstrap_system.sh
M fe/pom.xml
M shaded-deps/pom.xml
M tests/custom_cluster/test_kudu_table_create_without_hms.py
4 files changed, 37 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/15057/12
-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 12
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>

[Impala-ASF-CR] IMPALA-9287: Fix test kudu table create without hms in Hive3

Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Fix test_kudu_table_create_without_hms in Hive3
......................................................................


Patch Set 10:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15057/9/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/15057/9/bin/bootstrap_system.sh@315
PS9, Line 315: 500
> nit: 1500
Not 1500, but 500. 's/\(max_connections = \)\S*/\1500/g' this usage means: use '\1' to replace 'max_connections = ', '500' is the actual content which you want to update.


http://gerrit.cloudera.org:8080/#/c/15057/9/tests/custom_cluster/test_kudu_table_create_without_hms.py
File tests/custom_cluster/test_kudu_table_create_without_hms.py:

http://gerrit.cloudera.org:8080/#/c/15057/9/tests/custom_cluster/test_kudu_table_create_without_hms.py@32
PS9, Line 32:   @pytest.mark.execute_serially
> This should be removed, otherwise the test is skipped when using Hive3.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 10
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Tue, 04 Feb 2020 04:07:56 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9287: Fix test kudu table create without hms in Hive3

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Fix test_kudu_table_create_without_hms in Hive3
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15057/10/shaded-deps/pom.xml
File shaded-deps/pom.xml:

http://gerrit.cloudera.org:8080/#/c/15057/10/shaded-deps/pom.xml@89
PS10, Line 89:                 <include>org/apache/hadoop/hive/ql/optimizer/ppr/*</include>
I am curious to know what error do we see if we don't add this. Its surprising that metastore jar is leaking these classes into our classpath



-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 10
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Thu, 06 Feb 2020 07:03:10 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9287: Fixed the error of running test kudu table create without hms after setting USE CDP HIVE=true

Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Fixed the error of running test_kudu_table_create_without_hms after setting USE_CDP_HIVE=true
......................................................................


Patch Set 6:

(1 comment)

> (1 comment)

Thanks for your review, Vihang. The mainly error is lacking of jars(hive-metastoe/hive-exec and so on). Quanlong mentioned about shaded-deps/pom.xml, so tried to remov the hive-exec dependency in fe/pom.xml, and add some necessary class dependency in shaded-deps/pom.xml, avoiding involve other unrelated dependencies.

http://gerrit.cloudera.org:8080/#/c/15057/5/fe/pom.xml
File fe/pom.xml:

http://gerrit.cloudera.org:8080/#/c/15057/5/fe/pom.xml@1231
PS5, Line 1231:           <groupId>org.apache.hive</groupId>
> Adding hive-exec dependency is not recommended since it will bring along wi
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 6
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Tue, 21 Jan 2020 03:19:49 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
......................................................................


Patch Set 12:

(4 comments)

Thanks for your review. And I've already fixed this as possible.

http://gerrit.cloudera.org:8080/#/c/15057/10//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15057/10//COMMIT_MSG@7
PS10, Line 7: IMPALA-9287: Add support for embedded HMS in CDP builds
> I suggest modify the title of the JIRA which is more appropriate. Something
Done


http://gerrit.cloudera.org:8080/#/c/15057/10/fe/pom.xml
File fe/pom.xml:

http://gerrit.cloudera.org:8080/#/c/15057/10/fe/pom.xml@1210
PS10, Line 1210:         <!-- IMPALA-9287: Needed when catalogd used embedded HMS-->
> Since we are removing the test scope this comment can be edited/removed.
Done


http://gerrit.cloudera.org:8080/#/c/15057/10/fe/pom.xml@1214
PS10, Line 1214:           <version>3.2.0-m3</version>
> please add a <scope>runtime</scope> here, along with the comment pointing t
Done


http://gerrit.cloudera.org:8080/#/c/15057/10/fe/pom.xml@1233
PS10, Line 1233:           <groupId>org.apache.hive</groupId>
> can you add <scope>runtime</scope> here? Also, please add a comment as to w
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 12
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Thu, 06 Feb 2020 08:54:15 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
......................................................................


Patch Set 12:

> (1 comment)

The error is: cannot found class PartitionExpressionForMetastore. I add class one by one to keep pom files minimal, all including four classed.


-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 12
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Thu, 06 Feb 2020 08:56:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
......................................................................


Patch Set 12:

(2 comments)

> > (1 comment)
 > 
 > The error is: cannot found class PartitionExpressionForMetastore. I
 > add class one by one to keep pom files minimal, all including four
 > classed.

Ah I see. I think this can be fixed by setting metastore.expression.proxy to org.apache.hadoop.hive.metastore.DefaultPartitionExpressionProxy in the hive-site.xml.py if hive_major_version >=3 here: https://github.com/apache/impala/blob/master/fe/src/test/resources/hive-site.xml.py#L93

The PartitionExpressionProxy API is only usable by Hive since it uses some of its internal classes which are unavailable to non-hive applications. Refer https://cwiki.apache.org/confluence/display/Hive/AdminManual+Metastore+3.0+Administration standalone mode for more details.

http://gerrit.cloudera.org:8080/#/c/15057/12/fe/pom.xml
File fe/pom.xml:

http://gerrit.cloudera.org:8080/#/c/15057/12/fe/pom.xml@1065
PS12, Line 1065:           <scope>runtime</scope>
I would avoid making any changes to hive-2 profile since they seem unnecessary.


http://gerrit.cloudera.org:8080/#/c/15057/12/fe/pom.xml@1235
PS12, Line 1235:           <version>${hive.version}</version>
This dependency can be changed to a runtime scope here for hive-3 profile only since we don't want to depend on it for compilation.
<scope>runtime</scope>



-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 12
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Mon, 10 Feb 2020 18:45:27 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
......................................................................

IMPALA-9287: Add support for embedded HMS in CDP builds

In some situations, an embedded HMS is enough for catalogd server.
And we've already implemented this in IMPALA-8974. But after
setting USE_CDP_HIVE=true and rebuilt impala, the custom cluster
test case test_kudu_table_create_without_hms would failed due to
lacking of related jars. The solution is to add related maven
dependency in $IMPALA_HOME/fe/pom.xml and
$IMPALA_HOME/shaded-deps/pom.xml.

Tests:
  * Ran test_kudu_table_create_without_hms.py by setting
  USE_CDP_HIVE=true locally

Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Reviewed-on: http://gerrit.cloudera.org:8080/15057
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/bootstrap_system.sh
M fe/pom.xml
M fe/src/test/resources/hive-site.xml.py
M tests/custom_cluster/test_kudu_table_create_without_hms.py
4 files changed, 36 insertions(+), 4 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 15
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>

[Impala-ASF-CR] IMPALA-9287: Fix test kudu table create without hms in Hive3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Fix test_kudu_table_create_without_hms in Hive3
......................................................................


Patch Set 9:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5589/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 9
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Mon, 03 Feb 2020 14:39:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9287: Fixed the error of running test kudu table create without hms after setting USE CDP HIVE=true

Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Fixed the error of running test_kudu_table_create_without_hms after setting USE_CDP_HIVE=true
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15057/5/fe/pom.xml
File fe/pom.xml:

http://gerrit.cloudera.org:8080/#/c/15057/5/fe/pom.xml@1111
PS5, Line 1111:         <dependency>
              :           <groupId>org.apache.impala</groupId>
              :           <artifactId>impala-minimal-hive-exec</artifactId>
              :           <version>${project.version}</version>
              :         </dependency>
> We used a shaded version of hive-exec here. Defined in shaded-deps/pom.xml.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 6
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Tue, 21 Jan 2020 03:13:14 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
......................................................................


Patch Set 13:

Thanks for making the suggested change. I have triggered a job https://jenkins.impala.io/job/ubuntu-16.04-from-scratch-cdp-hive/62 which will run the core tests with the patch. Lets wait to for it to complete (takes about 3-4 hours). The patch looks good to me.


-- 
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 13
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Tue, 11 Feb 2020 05:02:53 +0000
Gerrit-HasComments: No