You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2017/07/28 09:01:40 UTC

Review Request 61206: Ambari Server Setup Code Fails Because of Missing Stack Upgrade

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61206/
-----------------------------------------------------------

Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-21595
    https://issues.apache.org/jira/browse/AMBARI-21595


Repository: ambari


Description
-------

On {{branch-feature-AMBARI-21450}}, there is a Python failure on ambari-server setup:

{code}
Using python  /usr/bin/python
Setup ambari-server
Traceback (most recent call last):
File "/usr/sbin/ambari-server.py", line 40, in <module>
from ambari_server.serverUpgrade import upgrade, upgrade_stack, set_current
ImportError: cannot import name upgrade_stack
{code}

This is most likely a cherry-pick issue from trunk where all "upgrade stack" code was removed. I think that we should also remove it from here as well since this will cause problems with PATCH repositories anyway.


Diffs
-----

  ambari-server/src/main/python/ambari-server.py b25cd16d49 
  ambari-server/src/main/python/ambari_server/setupActions.py 926db98c0d 
  ambari-server/src/test/python/TestAmbariServer.py fb0bb70b92 
  ambari-server/src/test/python/TestServerUpgrade.py 9235ff9f19 


Diff: https://reviews.apache.org/r/61206/diff/1/


Testing
-------

mvn clean test


Thanks,

Dmitro Lisnichenko


Re: Review Request 61206: Ambari Server Setup Code Fails Because of Missing Stack Upgrade

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61206/#review181658
-----------------------------------------------------------


Ship it!




Ship It!

- Nate Cole


On July 28, 2017, 5:01 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61206/
> -----------------------------------------------------------
> 
> (Updated July 28, 2017, 5:01 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-21595
>     https://issues.apache.org/jira/browse/AMBARI-21595
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> On {{branch-feature-AMBARI-21450}}, there is a Python failure on ambari-server setup:
> 
> {code}
> Using python  /usr/bin/python
> Setup ambari-server
> Traceback (most recent call last):
> File "/usr/sbin/ambari-server.py", line 40, in <module>
> from ambari_server.serverUpgrade import upgrade, upgrade_stack, set_current
> ImportError: cannot import name upgrade_stack
> {code}
> 
> This is most likely a cherry-pick issue from trunk where all "upgrade stack" code was removed. I think that we should also remove it from here as well since this will cause problems with PATCH repositories anyway.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/python/ambari-server.py b25cd16d49 
>   ambari-server/src/main/python/ambari_server/setupActions.py 926db98c0d 
>   ambari-server/src/test/python/TestAmbariServer.py fb0bb70b92 
>   ambari-server/src/test/python/TestServerUpgrade.py 9235ff9f19 
> 
> 
> Diff: https://reviews.apache.org/r/61206/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 61206: Ambari Server Setup Code Fails Because of Missing Stack Upgrade

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61206/#review181657
-----------------------------------------------------------


Ship it!




Ship It!

- Jonathan Hurley


On July 28, 2017, 5:01 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61206/
> -----------------------------------------------------------
> 
> (Updated July 28, 2017, 5:01 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-21595
>     https://issues.apache.org/jira/browse/AMBARI-21595
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> On {{branch-feature-AMBARI-21450}}, there is a Python failure on ambari-server setup:
> 
> {code}
> Using python  /usr/bin/python
> Setup ambari-server
> Traceback (most recent call last):
> File "/usr/sbin/ambari-server.py", line 40, in <module>
> from ambari_server.serverUpgrade import upgrade, upgrade_stack, set_current
> ImportError: cannot import name upgrade_stack
> {code}
> 
> This is most likely a cherry-pick issue from trunk where all "upgrade stack" code was removed. I think that we should also remove it from here as well since this will cause problems with PATCH repositories anyway.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/python/ambari-server.py b25cd16d49 
>   ambari-server/src/main/python/ambari_server/setupActions.py 926db98c0d 
>   ambari-server/src/test/python/TestAmbariServer.py fb0bb70b92 
>   ambari-server/src/test/python/TestServerUpgrade.py 9235ff9f19 
> 
> 
> Diff: https://reviews.apache.org/r/61206/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>