You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by Robert Burrell Donkin <ro...@gmail.com> on 2008/08/13 20:39:40 UTC

[jsieve] Please review RC1

i've cut a release candidate for jsieve:

http://people.apache.org/~rdonkin/james/org/apache/james/apache-jsieve/0.2RC1/

please review

note that the release candidate isn't signed but the FC will be

- robert

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: [jsieve] Please review RC1

Posted by Stefano Bagnara <ap...@bago.org>.
Stefano Bagnara ha scritto:
> Robert Burrell Donkin ha scritto:
>> On Wed, Aug 13, 2008 at 9:22 PM, Bernd Fondermann 
>> <bf...@brainlounge.de> wrote:
>>> Robert Burrell Donkin wrote:
>>>> i've cut a release candidate for jsieve:
>>>>
>>>>
>>>> http://people.apache.org/~rdonkin/james/org/apache/james/apache-jsieve/0.2RC1/ 
>>>>
>>> great!
>>>
>>>> please review
>>> * the zip containing javadocs is named .jar
>>> (apache-jsieve-0.2RC1-javadoc.jar) which is a little bit confusing.
>>
>> this is a mavenism :-/
>>
>> anyone know how to fix this?
> 
> IMHO this is NOT a bug and should not be fixed. Most IDEs lookup for 
> javadoc.jar nowadays. This is the "standard" way to publish javadocs for 
> jars. This is the same of the -sources.jar
> 
> At most I would do like we do in mime4j and add javadocs to the binary 
> distribution, too.
> Maybe the issue is that in the src/assemble/bin.xml we have:
>     <fileSet>
>       <directory>target/site/apidocs</directory>
>       <outputDirectory>javadocs</outputDirectory>
>     </fileSet>
> while the right directory is "target/apidocs".
> 
> It's not clear to me why the binary for the mime4j build from Oleg 
> correctly include the javadoc while this one doesn't as the pom.xml are 
> identical... Maybe tomorrow I'll find the time to check this, if no one 
> do this earlier.

I've done this. javadocs folder is now in the binary distribution.

>>> * the NOTICE file in *src.zip does not reference bnd-0.0.249.jar and 
>>> junit
>>> which are distributed in the zips stage directory
>>
>> anyone know how to fix this?
> 
> The NOTICE.txt in the src folder is the one that you placed in the root 
> of the svn tree. I guess you only have to add all of the notices to that 
> file.

Done.

Stefano

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: [jsieve] Please review RC1

Posted by Stefano Bagnara <ap...@bago.org>.
Robert Burrell Donkin ha scritto:
> On Wed, Aug 13, 2008 at 9:22 PM, Bernd Fondermann <bf...@brainlounge.de> wrote:
>> Robert Burrell Donkin wrote:
>>> i've cut a release candidate for jsieve:
>>>
>>>
>>> http://people.apache.org/~rdonkin/james/org/apache/james/apache-jsieve/0.2RC1/
>> great!
>>
>>> please review
>> * the zip containing javadocs is named .jar
>> (apache-jsieve-0.2RC1-javadoc.jar) which is a little bit confusing.
> 
> this is a mavenism :-/
> 
> anyone know how to fix this?

IMHO this is NOT a bug and should not be fixed. Most IDEs lookup for 
javadoc.jar nowadays. This is the "standard" way to publish javadocs for 
jars. This is the same of the -sources.jar

At most I would do like we do in mime4j and add javadocs to the binary 
distribution, too.
Maybe the issue is that in the src/assemble/bin.xml we have:
     <fileSet>
       <directory>target/site/apidocs</directory>
       <outputDirectory>javadocs</outputDirectory>
     </fileSet>
while the right directory is "target/apidocs".

It's not clear to me why the binary for the mime4j build from Oleg 
correctly include the javadoc while this one doesn't as the pom.xml are 
identical... Maybe tomorrow I'll find the time to check this, if no one 
do this earlier.

>> * the NOTICE file in *src.zip does not reference bnd-0.0.249.jar and junit
>> which are distributed in the zips stage directory
> 
> anyone know how to fix this?

The NOTICE.txt in the src folder is the one that you placed in the root 
of the svn tree. I guess you only have to add all of the notices to that 
file.

Stefano

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: [jsieve] Please review RC1

Posted by Robert Burrell Donkin <ro...@gmail.com>.
On Wed, Aug 13, 2008 at 9:22 PM, Bernd Fondermann <bf...@brainlounge.de> wrote:
> Robert Burrell Donkin wrote:
>>
>> i've cut a release candidate for jsieve:
>>
>>
>> http://people.apache.org/~rdonkin/james/org/apache/james/apache-jsieve/0.2RC1/
>
> great!
>
>>
>> please review
>
> * the zip containing javadocs is named .jar
> (apache-jsieve-0.2RC1-javadoc.jar) which is a little bit confusing.

this is a mavenism :-/

anyone know how to fix this?

> * the NOTICE file in *src.zip does not reference bnd-0.0.249.jar and junit
> which are distributed in the zips stage directory

anyone know how to fix this?

- robert

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: [jsieve] Please review RC1

Posted by Bernd Fondermann <bf...@brainlounge.de>.
Robert Burrell Donkin wrote:
> i've cut a release candidate for jsieve:
> 
> http://people.apache.org/~rdonkin/james/org/apache/james/apache-jsieve/0.2RC1/

great!

> 
> please review

* the zip containing javadocs is named .jar 
(apache-jsieve-0.2RC1-javadoc.jar) which is a little bit confusing.

* the NOTICE file in *src.zip does not reference bnd-0.0.249.jar and 
junit which are distributed in the zips stage directory

otherwise: +1

   Bernd






---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org