You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "rmoff (via GitHub)" <gi...@apache.org> on 2024/09/05 11:24:05 UTC
[PR] Add docs and config entry for default log level config setting (ref FLINK-33166 / #23476) [flink]
rmoff opened a new pull request, #25290:
URL: https://github.com/apache/flink/pull/25290
## What is the purpose of the change
Make it easier to discover the configuration that will help users when troubleshooting to increase logging level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add docs and config entry for default log level config setting [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #25290:
URL: https://github.com/apache/flink/pull/25290#discussion_r1760819433
##########
docs/content/docs/deployment/advanced/logging.md:
##########
@@ -67,6 +67,8 @@ The Flink distribution ships with the following log4j properties files in the `c
Log4j periodically scans this file for changes and adjusts the logging behavior if necessary.
By default this check happens every 30 seconds and is controlled by the `monitorInterval` setting in the Log4j properties files.
+You can configure the default logging level using the [`env.log.level` configuration]({{< ref "docs/deployment/config">}}#jvm-and-logging-options).
Review Comment:
The sentence at the top says "Log4j 2 is controlled using property files." This is not correct - we add and also the configuration.
Maybe have 2 subsections one for the properties and one for the configuration. I suggest documenting the other 2 log related configurations options also here.
I think is is confusing using the word default - as this setting has a default. I think it would be easier to parse using words like : you can configure the logging level max and dir in the configuration . The logging level specified in the configuration can be overridden in the log4j property files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add docs and config entry for default log level config setting [flink]
Posted by "rmoff (via GitHub)" <gi...@apache.org>.
rmoff commented on PR #25290:
URL: https://github.com/apache/flink/pull/25290#issuecomment-2333476925
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add docs and config entry for default log level config setting [flink]
Posted by "rmoff (via GitHub)" <gi...@apache.org>.
rmoff commented on code in PR #25290:
URL: https://github.com/apache/flink/pull/25290#discussion_r1771749664
##########
docs/content/docs/deployment/advanced/logging.md:
##########
@@ -67,6 +67,8 @@ The Flink distribution ships with the following log4j properties files in the `c
Log4j periodically scans this file for changes and adjusts the logging behavior if necessary.
By default this check happens every 30 seconds and is controlled by the `monitorInterval` setting in the Log4j properties files.
+You can configure the default logging level using the [`env.log.level` configuration]({{< ref "docs/deployment/config">}}#jvm-and-logging-options).
Review Comment:
Good points. Updated.
##########
flink-dist/src/main/resources/config.yaml:
##########
@@ -22,6 +22,9 @@ env:
java:
opts:
all: --add-exports=java.base/sun.net.util=ALL-UNNAMED --add-exports=java.rmi/sun.rmi.registry=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-exports=java.security.jgss/sun.security.krb5=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --add-opens=java.base/java.nio=ALL-UNNAMED --add-opens=java.base/sun.nio.ch=ALL-UNNAMED --add-opens=java.base/java.lang.reflect=ALL-UNNAMED --add-opens=java.base/java.text=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.at
omic=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.locks=ALL-UNNAMED
+# # Default log level
Review Comment:
Good points. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add docs and config entry for default log level config setting [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #25290:
URL: https://github.com/apache/flink/pull/25290#issuecomment-2331291646
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fb5341c9700e38b03589375dcdefd0a5f1881088",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fb5341c9700e38b03589375dcdefd0a5f1881088",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fb5341c9700e38b03589375dcdefd0a5f1881088 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add docs and config entry for default log level config setting [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #25290:
URL: https://github.com/apache/flink/pull/25290#discussion_r1760820564
##########
flink-dist/src/main/resources/config.yaml:
##########
@@ -22,6 +22,9 @@ env:
java:
opts:
all: --add-exports=java.base/sun.net.util=ALL-UNNAMED --add-exports=java.rmi/sun.rmi.registry=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-exports=java.security.jgss/sun.security.krb5=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --add-opens=java.base/java.nio=ALL-UNNAMED --add-opens=java.base/sun.nio.ch=ALL-UNNAMED --add-opens=java.base/java.lang.reflect=ALL-UNNAMED --add-opens=java.base/java.text=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.at
omic=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.locks=ALL-UNNAMED
+# # Default log level
Review Comment:
as per the the other comment - I suggest not using the word default and also including the otehr logging configuration options here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org