You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/03 07:48:38 UTC
[GitHub] [incubator-shardingsphere] cherrylzhao opened a new pull request
#5060: fix connection.getSchema error
cherrylzhao opened a new pull request #5060: fix connection.getSchema error
URL: https://github.com/apache/incubator-shardingsphere/pull/5060
add CatalogSchemaPair to fix connection.getSchema error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao closed pull request #5060:
fix connection.getSchema error
Posted by GitBox <gi...@apache.org>.
cherrylzhao closed pull request #5060: fix connection.getSchema error
URL: https://github.com/apache/incubator-shardingsphere/pull/5060
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5060: fix
connection.getSchema error
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5060: fix connection.getSchema error
URL: https://github.com/apache/incubator-shardingsphere/pull/5060#issuecomment-608298744
## Pull Request Test Coverage Report for [Build 10818](https://coveralls.io/builds/29817543)
* **13** of **28** **(46.43%)** changed or added relevant lines in **5** files are covered.
* **1** unchanged line in **1** file lost coverage.
* Overall coverage decreased (**-0.02%**) to **57.173%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/schema/SchemaMetaDataLoader.java](https://coveralls.io/builds/29817543/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Fschema%2FSchemaMetaDataLoader.java#L83) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/table/TableMetaDataLoader.java](https://coveralls.io/builds/29817543/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Ftable%2FTableMetaDataLoader.java#L46) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/index/IndexMetaDataLoader.java](https://coveralls.io/builds/29817543/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Findex%2FIndexMetaDataLoader.java#L49) | 0 | 2 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/util/CatalogSchemaPair.java](https://coveralls.io/builds/29817543/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Futil%2FCatalogSchemaPair.java#L56) | 7 | 18 | 38.89%
<!-- | **Total:** | **13** | **28** | **46.43%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaDataLoader.java](https://coveralls.io/builds/29817543/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Fcolumn%2FColumnMetaDataLoader.java#L58) | 1 | 85.42% |
<!-- | **Total:** | **1** | | -->
| Totals | [](https://coveralls.io/builds/29817543) |
| :-- | --: |
| Change from base [Build 10816](https://coveralls.io/builds/29816582): | -0.02% |
| Covered Lines: | 11713 |
| Relevant Lines: | 20487 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #5060:
fix connection.getSchema error
Posted by GitBox <gi...@apache.org>.
cherrylzhao commented on issue #5060: fix connection.getSchema error
URL: https://github.com/apache/incubator-shardingsphere/pull/5060#issuecomment-608322065
it's better to create another connection adapter to override the getCatalog and getSchema method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services