You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/03/09 22:09:15 UTC
[GitHub] [incubator-gobblin] jack-moseley opened a new pull request #2915:
[GOBBLIN-1075] Add option to return latest failed flows
jack-moseley opened a new pull request #2915: [GOBBLIN-1075] Add option to return latest failed flows
URL: https://github.com/apache/incubator-gobblin/pull/2915
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1075
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
Add query boolean option that will only return failed flow statuses/executions.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Updated test
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] jack-moseley commented on issue #2915:
[GOBBLIN-1075] Add option to return latest failed flows
Posted by GitBox <gi...@apache.org>.
jack-moseley commented on issue #2915: [GOBBLIN-1075] Add option to return latest failed flows
URL: https://github.com/apache/incubator-gobblin/pull/2915#issuecomment-597348316
> I think instead of giving an option to return "failed" flows, we should give option to return flows with ANY status. e.g. how many flows are in COMPILED state, how many are RUNNING.... and so on
This is a good idea, I modified it to instead take a query like `&executionStatus=RUNNING` which will return the last running flow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] arjun4084346 commented on issue #2915:
[GOBBLIN-1075] Add option to return latest failed flows
Posted by GitBox <gi...@apache.org>.
arjun4084346 commented on issue #2915: [GOBBLIN-1075] Add option to return latest failed flows
URL: https://github.com/apache/incubator-gobblin/pull/2915#issuecomment-596817919
We should also code it in an flexible way, so that now the filter supports a particular flow status(es) , and in future maybe a filter to support all GET flowConfigs with a particular config.
The second point can be really helpful, when users(SREs) have to add/change one config to multiple flows. This has happened in past. cc @Pawan Reddy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io commented on issue #2915:
[GOBBLIN-1075] Add option to return latest failed flows
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #2915: [GOBBLIN-1075] Add option to return latest failed flows
URL: https://github.com/apache/incubator-gobblin/pull/2915#issuecomment-596841705
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2915?src=pr&el=h1) Report
> Merging [#2915](https://codecov.io/gh/apache/incubator-gobblin/pull/2915?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/f3d75e392c554771e3c098cafb648ec55fa40ba7?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2915?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2915 +/- ##
============================================
- Coverage 45.87% 45.87% -0.01%
- Complexity 9190 9191 +1
============================================
Files 1934 1934
Lines 72931 72948 +17
Branches 8046 8051 +5
============================================
+ Hits 33458 33465 +7
- Misses 36404 36414 +10
Partials 3069 3069
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2915?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/gobblin/service/FlowExecutionClient.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2915/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93RXhlY3V0aW9uQ2xpZW50LmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...org/apache/gobblin/service/FlowStatusResource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2915/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93U3RhdHVzUmVzb3VyY2UuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../apache/gobblin/service/FlowExecutionResource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2915/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93RXhlY3V0aW9uUmVzb3VyY2UuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...a/org/apache/gobblin/service/FlowStatusClient.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2915/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93U3RhdHVzQ2xpZW50LmphdmE=) | `72.34% <100%> (ø)` | `7 <0> (ø)` | :arrow_down: |
| [...obblin/service/monitoring/FlowStatusGenerator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2915/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9GbG93U3RhdHVzR2VuZXJhdG9yLmphdmE=) | `48% <5.88%> (-21.7%)` | `11 <0> (ø)` | |
| [...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2915/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=) | `72.22% <0%> (+2.22%)` | `13% <0%> (ø)` | :arrow_down: |
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2915/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `41.73% <0%> (+3.47%)` | `15% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2915?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2915?src=pr&el=footer). Last update [f3d75e3...738dd73](https://codecov.io/gh/apache/incubator-gobblin/pull/2915?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] jack-moseley commented on issue #2915:
[GOBBLIN-1075] Add option to return latest failed flows
Posted by GitBox <gi...@apache.org>.
jack-moseley commented on issue #2915: [GOBBLIN-1075] Add option to return latest failed flows
URL: https://github.com/apache/incubator-gobblin/pull/2915#issuecomment-599400689
@sv2000 please merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] jack-moseley commented on issue #2915:
[GOBBLIN-1075] Add option to return latest failed flows
Posted by GitBox <gi...@apache.org>.
jack-moseley commented on issue #2915: [GOBBLIN-1075] Add option to return latest failed flows
URL: https://github.com/apache/incubator-gobblin/pull/2915#issuecomment-597349479
> We should also code it in an flexible way, so that now the filter supports a particular flow status(es) , and in future maybe a filter to support all GET flowConfigs with a particular config.
> The second point can be really helpful, when users(SREs) have to add/change one config to multiple flows. This has happened in past. cc @pawan Reddy
I'm not sure if that should be relevant to this PR, since the code paths for getting flowstatus/flowconfig are completely separate, and I don't think there's much else in flowstatus that would be useful to query by.
Maybe that is a change to getting flowconfig that we could do in the future though (being able to query which flowconfig have a particular key set, etc.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] arjun4084346 commented on issue #2915:
[GOBBLIN-1075] Add option to return latest failed flows
Posted by GitBox <gi...@apache.org>.
arjun4084346 commented on issue #2915: [GOBBLIN-1075] Add option to return latest failed flows
URL: https://github.com/apache/incubator-gobblin/pull/2915#issuecomment-596816593
I think instead of giving an option to return "failed" flows, we should give option to return flows with ANY status. e.g. how many flows are in COMPILED state, how many are RUNNING.... and so on
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] jack-moseley commented on issue #2915:
[GOBBLIN-1075] Add option to return latest failed flows
Posted by GitBox <gi...@apache.org>.
jack-moseley commented on issue #2915: [GOBBLIN-1075] Add option to return latest failed flows
URL: https://github.com/apache/incubator-gobblin/pull/2915#issuecomment-596803339
@arjun4084346 please review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] arjun4084346 commented on issue #2915:
[GOBBLIN-1075] Add option to return latest failed flows
Posted by GitBox <gi...@apache.org>.
arjun4084346 commented on issue #2915: [GOBBLIN-1075] Add option to return latest failed flows
URL: https://github.com/apache/incubator-gobblin/pull/2915#issuecomment-598894223
+1 LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] asfgit closed pull request #2915:
[GOBBLIN-1075] Add option to return latest failed flows
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2915: [GOBBLIN-1075] Add option to return latest failed flows
URL: https://github.com/apache/incubator-gobblin/pull/2915
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services