You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Jeff Trawick <tr...@gmail.com> on 2004/09/23 12:25:43 UTC
Re: cvs commit: apr/threadproc/win32 thread.c
On 23 Sep 2004 06:17:59 -0000, mturk@apache.org <mt...@apache.org> wrote:
> mturk 2004/09/22 23:17:59
>
> Modified: threadproc/win32 Tag: APR_0_9_BRANCH thread.c
> Log:
> Backport from HEAD.
> Makes the threads to behave like on posix. If the thread is created without
> APR_DETACH expect that the thread_join will be called, so don't close the
> handle in advance, if the thread has already finished.
> Reviewed by: wrowe
you've got some isolated CR characters in your commit that need to be
cleaned up; here is one example:
if ((*new) == NULL) {
return APR_ENOMEM;
}
(*new)->pool = pool;
(*new)->detach = 0;^M <----------
return APR_SUCCESS;
}
also, if committing CHANGES separately from thread.c was intentional,
please try to commit them together in the future so that the related
change appears in the same commit log
if you have a broken cvs client which fails to commit files in the
current directory if there are other files to commit as well, you can
change to .. and do a commit on (for example) "apr/CHANGES
apr/threadproc/win32/thread.c" to work around the bogosity