You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/06/12 07:03:59 UTC
[GitHub] [hive] kishendas commented on a change in pull request #1095: Make all DDLs transactional and advance commit write ID, so that subsequent read will invalidate the cache entry.
kishendas commented on a change in pull request #1095:
URL: https://github.com/apache/hive/pull/1095#discussion_r439243766
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java
##########
@@ -73,11 +76,11 @@ public long openTxn(Context ctx, String user) throws LockException {
@Override
public boolean isTxnOpen() {
- return false;
+ return numTxn != 0;
Review comment:
Makes sense. Reverting. Picked up this from Daniel's patch thinking this is used in some cases. Will revisit this change, if some tests fail because of this. But logically speaking, this should not be required, as it doesn't support transactions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org