[jira] [Commented] (FLINK-3405) Extend NiFiSource with interface StoppableFunction

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15305774#comment-15305774 ] 

ASF GitHub Bot commented on FLINK-3405:
---------------------------------------

GitHub user smarthi opened a pull request:

    https://github.com/apache/flink/pull/2047

    FLINK-3405: Extend NiFiSource with interface StoppableFunction

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/smarthi/flink Flink-3405

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2047.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2047
    
----
commit c2daeb8eb81d7b1a0151bb0237ee94d048da6f44
Author: smarthi <sm...@apache.org>
Date:   2016-05-29T06:15:16Z

    FLINK-3405: Extend NiFiSource with interface StoppableFunction

----


> Extend NiFiSource with interface StoppableFunction
> --------------------------------------------------
>
>                 Key: FLINK-3405
>                 URL: https://issues.apache.org/jira/browse/FLINK-3405
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming Connectors
>            Reporter: Matthias J. Sax
>            Assignee: Suneel Marthi
>
> Nifi source is not stoppable right now. To make it stoppable, is must implement {{StoppableFunction}}. Implementing method {{stop()}} must ensure, that the source stops receiving new messages from Nifi and issues a final checkpoint. Afterwards, {{run()}} must return.
> When implementing this, keep in mind, that the gathered checkpoint might later be used as a savepoint.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)