You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/08/10 07:27:08 UTC
[GitHub] [incubator-yunikorn-k8shim] adamantal opened a new pull request #178: [YUNIKORN-354] Update YK base docker images to UBI
adamantal opened a new pull request #178:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/178
Updated the base Docker image for the container
Questions:
- [ ] where should be changed the helm charts?
- [ ] should the base image for the admission controller be changed?
- [ ] add license for UBI image if needed
Tested:
locally using `make clean run` on docker-desktop
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] adamantal commented on pull request #178: [YUNIKORN-354] Update YK base docker images to UBI
Posted by GitBox <gi...@apache.org>.
adamantal commented on pull request #178:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/178#issuecomment-680105268
Since the RedHat Docker registry requires authentication which may conflict with the ASF policies we decided to abandon this patch and try a downstream solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] kingamarton commented on pull request #178: [YUNIKORN-354] Update YK base docker images to UBI
Posted by GitBox <gi...@apache.org>.
kingamarton commented on pull request #178:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/178#issuecomment-671206792
@adamantal The helm charts are located in the release repository: https://github.com/apache/incubator-yunikorn-release/tree/master/helm-charts/yunikorn
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #178: [YUNIKORN-354] Update YK base docker images to UBI
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #178:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/178#issuecomment-671660019
Looks like the e2e test is failing due to:
> Step 1/34 : FROM registry.redhat.io/ubi8/go-toolset:1.12.8-45
Get https://registry.redhat.io/v2/ubi8/go-toolset/manifests/1.12.8-45: unauthorized: Please login to the Red Hat Registry using your Customer Portal credentials. Further instructions can be found here: https://access.redhat.com/RegistryAuthentication
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] adamantal closed pull request #178: [YUNIKORN-354] Update YK base docker images to UBI
Posted by GitBox <gi...@apache.org>.
adamantal closed pull request #178:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/178
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on pull request #178: [YUNIKORN-354] Update YK base docker images to UBI
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #178:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/178#issuecomment-680412355
UBIs from RedHat are set to be moved into authenticated access only registries. That will require a RH account and thus acceptance of the terms that come with it. We would still need further entitlements to be able to add packages etc in the base image.
I don't think that is a good idea for an Apache release.
I am a -1 on this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org