[GitHub] [skywalking-swck] wu-sheng commented on a change in pull request #25: Some enhancements for HPA metric adapter

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #25:
URL: https://github.com/apache/skywalking-swck/pull/25#discussion_r600498236



##########
File path: docs/custom-metrics-adapter.md
##########
@@ -51,13 +52,31 @@ External metrics allow you to autoscale your cluster based on any metric availab
 ```
 
  * metric_name: The name of metric generated by OAL or other subsystem.
- * label: `label_key` is from the arguments of swctl . 
+ * label: `label_key` is the entity name of skywalking metrics. if the label value contains special characters more than
+   `.`, `-` and `_`, `service.str.<number>` represent the literal of label value, and `service.byte.<number>` could 
+   encode these special characters to hex bytes.
+   
+Supposing the service name is `v1|productpage|bookinfo|demo`, the `matchLabels` should be like the below piece:
+
+```yaml
+matchLabels:
+  "service.str.0":  "v1"
+  "service.byte.1": "7c" // the hex byte of "|"

Review comment:
       Interesting.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org