You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by xiaokang <gi...@git.apache.org> on 2014/11/17 09:27:32 UTC
[GitHub] storm pull request: STORM-558 change "swap!" to "reset!" to fix as...
GitHub user xiaokang opened a pull request:
https://github.com/apache/storm/pull/315
STORM-558 change "swap!" to "reset!" to fix assignment-versions always empty in supervisor
This PR is for JIRA STORM-558 to fix #167 .
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xiaokang/incubator-storm STORM-558
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/315.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #315
----
commit 32a7c0b161f833f0bae2fe8ee6515af8f899829b
Author: Kang Xiao <kx...@gmail.com>
Date: 2014-11-17T07:29:15Z
STORM-558 change "swap!" to "reset!" to fix assignment-versions always
empty in supervisor
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-558 change "swap!" to "reset!" to fix as...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/315#issuecomment-63320364
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-558 change "swap!" to "reset!" to fix as...
Posted by Parth-Brahmbhatt <gi...@git.apache.org>.
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/315#issuecomment-63344283
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-558 change "swap!" to "reset!" to fix as...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/315#issuecomment-63373190
Thanks @xiaokang. I merged this into the master and 0.9.3 branches.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-558 change "swap!" to "reset!" to fix as...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/315#issuecomment-63318696
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-558 change "swap!" to "reset!" to fix as...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/315
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-558 change "swap!" to "reset!" to fix as...
Posted by xiaokang <gi...@git.apache.org>.
Github user xiaokang commented on the pull request:
https://github.com/apache/storm/pull/315#issuecomment-63317848
The failure was due to node.js multilang test case and it's solved after I installed a node.js binary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-558 change "swap!" to "reset!" to fix as...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/315#issuecomment-63326875
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-558 change "swap!" to "reset!" to fix as...
Posted by xiaokang <gi...@git.apache.org>.
Github user xiaokang commented on the pull request:
https://github.com/apache/storm/pull/315#issuecomment-63273340
The unit test is failed BOTH before and after this code change. I'll try to find the problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-558 change "swap!" to "reset!" to fix as...
Posted by nathanmarz <gi...@git.apache.org>.
Github user nathanmarz commented on the pull request:
https://github.com/apache/storm/pull/315#issuecomment-63348326
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---