You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/25 10:24:05 UTC
[GitHub] [incubator-doris] jackwener opened a new issue, #9775: [Enhancement] Remove the redundant `this.`
jackwener opened a new issue, #9775:
URL: https://github.com/apache/incubator-doris/issues/9775
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues.
### Description
Remove uncessary `this.`
Most scenario, it just use in `constructor`.
### Solution
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Vikasss7663 commented on issue #9775: [Enhancement] Remove the redundant `this.`
Posted by GitBox <gi...@apache.org>.
Vikasss7663 commented on issue #9775:
URL: https://github.com/apache/incubator-doris/issues/9775#issuecomment-1138265113
So should I have to remove this from "fe/fe-core/src/main/java" only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Vikasss7663 commented on issue #9775: [Enhancement] Remove the redundant `this.`
Posted by GitBox <gi...@apache.org>.
Vikasss7663 commented on issue #9775:
URL: https://github.com/apache/incubator-doris/issues/9775#issuecomment-1139753437
can you help me with what should I write in PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener closed issue #9775: [Enhancement] Remove the redundant `this.`
Posted by GitBox <gi...@apache.org>.
jackwener closed issue #9775: [Enhancement] Remove the redundant `this.`
URL: https://github.com/apache/incubator-doris/issues/9775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener commented on issue #9775: [Enhancement] Remove the redundant `this.`
Posted by GitBox <gi...@apache.org>.
jackwener commented on issue #9775:
URL: https://github.com/apache/incubator-doris/issues/9775#issuecomment-1138184514
You can find code in `fe/`.
If there are redundant `this.`, you can remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener commented on issue #9775: [Enhancement] Remove the redundant `this.`
Posted by GitBox <gi...@apache.org>.
jackwener commented on issue #9775:
URL: https://github.com/apache/incubator-doris/issues/9775#issuecomment-1149374416
This issue isn't necessary, and it will make `cherry-pick` harder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Vikasss7663 commented on issue #9775: [Enhancement] Remove the redundant `this.`
Posted by GitBox <gi...@apache.org>.
Vikasss7663 commented on issue #9775:
URL: https://github.com/apache/incubator-doris/issues/9775#issuecomment-1138177476
Hey @jackwener
I am a beginner and never contributed to any open source.
I want to work on this, can you help me with this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Vikasss7663 commented on issue #9775: [Enhancement] Remove the redundant `this.`
Posted by GitBox <gi...@apache.org>.
Vikasss7663 commented on issue #9775:
URL: https://github.com/apache/incubator-doris/issues/9775#issuecomment-1141712124
can you check now ?
I have just edited 1 files for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener commented on issue #9775: [Enhancement] Remove the redundant `this.`
Posted by GitBox <gi...@apache.org>.
jackwener commented on issue #9775:
URL: https://github.com/apache/incubator-doris/issues/9775#issuecomment-1139602361
you can spilt them into multiple PR
VISHAL SINGH ***@***.***> 于 2022年5月27日周五 19:15写道：
> I have removed from these 7 packages, should I create pr now or after
> doing in all packages because that would be huge.
>
> 1. alter
> 2. analysis
> 3. backup
> 4. blockrule
> 5. catalog
> 6. task
> 7. transaction
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-doris/issues/9775#issuecomment-1139522715>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AHI4SLO6LHZSLH27GLBIYDLVMCVE3ANCNFSM5W4UBGBA>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener commented on issue #9775: [Enhancement] Remove the redundant `this.`
Posted by GitBox <gi...@apache.org>.
jackwener commented on issue #9775:
URL: https://github.com/apache/incubator-doris/issues/9775#issuecomment-1138183981
> Hey @jackwener I am a beginner and never contributed to any open source. I want to work on this, can you help me with this issue.
It's ok😀, let's me explain this issue.
In Java, we can use `this.` to access `class member variables` like `if (this.name == jackwener)`.
But, in most scenario, it's redundant. just use in constructor like:
```java
class Person {
public string name;
Person(name) {
this.name = name;
}
boolean isJack() {
this.name == "jack"; // It's redundant;
}
}
```
So, we can remove the redundant like `isJack()`.
example in #8862 `fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsJobManager.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Vikasss7663 commented on issue #9775: [Enhancement] Remove the redundant `this.`
Posted by GitBox <gi...@apache.org>.
Vikasss7663 commented on issue #9775:
URL: https://github.com/apache/incubator-doris/issues/9775#issuecomment-1139766728
I don't feel like it's my first pr 🤣
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Vikasss7663 commented on issue #9775: [Enhancement] Remove the redundant `this.`
Posted by GitBox <gi...@apache.org>.
Vikasss7663 commented on issue #9775:
URL: https://github.com/apache/incubator-doris/issues/9775#issuecomment-1139522715
I have removed from these 7 packages, should I create pr now or after doing in all packages because that would be huge.
1. alter
2. analysis
3. backup
4. blockrule
5. catalog
6. task
7. transaction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener commented on issue #9775: [Enhancement] Remove the redundant `this.`
Posted by GitBox <gi...@apache.org>.
jackwener commented on issue #9775:
URL: https://github.com/apache/incubator-doris/issues/9775#issuecomment-1138273262
> So should I have to remove this from "fe/fe-core/src/main/java" only?
Yes, It's enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org