[GitHub] brodybits opened a new pull request #278: [CB-14145 WIP] patch release fix to resolve npm audit warnings - WIP PENDING upstream cordova-common patch

[GitBox <gi...@apache.org>]

brodybits opened a new pull request #278: [CB-14145 WIP] patch release fix to resolve npm audit warnings - WIP PENDING upstream cordova-common patch
URL: https://github.com/apache/cordova-windows/pull/278
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   Windows
   
   ### What does this PR do?
   
   - Use _`brodybits/cordova-common#plist-2-patch`_ to resolve `npm audit` warnings without generating engine warning on node 4 ref: apache/cordova-common#31
   
   __WIP TODO:__
   
   - [ ] _use cordova-coho to mark `6.0.1-dev`_
   - [ ] _include recent cordova-js update - TBD still waiting for final VOTE result_
   
   ### What testing has been done on this change?
   
   - `npm install` on node 4 does not generate any engine warning messages
   - `npm audit` shows no warnings on `npm@6.1.0`
   
   __TEST TODO items:__
   
   - [ ] _verify `npm test` passes on Travis CI_
   - [ ] _do `cordova platform add brodybits/cordova-windows#cb-14145-patch-update` on new Cordova project and verify that it runs on Windows (both desktop and mobile)_
   - [ ] _do `cordova platform add brodybits/cordova-windows#cb-14145-patch-update` on `cordova-sqlite-storage` test suite (`cordova-sqlite-spec` project) and verify that it succeeds on Windows (both desktop and mobile)_
   
   ### Checklist
   
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. _(marked XXX since the commit needs to be updated once the `cordova-common` update proposed in apache/cordova-common#31 is published to npm)_
   - ~~Added automated test coverage as appropriate for this change.~~
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org