You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by hdendukuri <gi...@git.apache.org> on 2016/02/12 22:05:00 UTC
[GitHub] incubator-eagle pull request: EAGLE-154 hadoop-metric monitoring s...
GitHub user hdendukuri opened a pull request:
https://github.com/apache/incubator-eagle/pull/87
EAGLE-154 hadoop-metric monitoring sandbox starter script
Create a sandbox start script that makes sure, Hadoop metric monitoring runs on new sandbox.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hdendukuri/incubator-eagle master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/87.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #87
----
commit 6f377c77b7e7efd31181645ff6640f0ca4d40bc2
Author: hdendukuri <hd...@ebay.com>
Date: 2016-02-12T20:54:28Z
update file access permission 755 to hadoop-metric-init.sh file. Added Eagle home path ${EAGLE_HOME} to locate sandbox-hadoopjmx-topology.conf in hadoop-metric-monitoring.sh.
commit fb5d607aef6458cc3f7db0935318b55714fb77ee
Author: hdendukuri <hd...@ebay.com>
Date: 2016-02-12T20:57:46Z
hadoop-metric monitoring sandbox starter script and policy creation.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: EAGLE-154 hadoop-metric monitoring s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-eagle/pull/87
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: EAGLE-154 hadoop-metric monitoring s...
Posted by yonzhang <gi...@git.apache.org>.
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/87#issuecomment-185321913
reviewed please merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: EAGLE-154 hadoop-metric monitoring s...
Posted by yonzhang <gi...@git.apache.org>.
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/87#issuecomment-184918333
Looks good, but 2 minor issues.
1) echo $job should be changed to echo "$job", otherwise it will show something strange because of literal character "*"
2) unit test is passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---