You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Darren Shepherd (JIRA)" <ji...@apache.org> on 2007/10/02 06:18:36 UTC
[jira] Created: (WW-2226) TextProvider.class should not be
registered as a Singleton
TextProvider.class should not be registered as a Singleton
----------------------------------------------------------
Key: WW-2226
URL: https://issues.apache.org/struts/browse/WW-2226
Project: Struts 2
Issue Type: Bug
Components: API, Configuration
Affects Versions: 2.0.9
Reporter: Darren Shepherd
TextProvider.class should be not registered in the Container as a Singleton. If the TextProvider impl is an instanceof ResourceBundleTextProvider, the TextProviderFactory will call setClazz, and setLocaleProvider on the impl. This is not thread safe. This is related an xwork bug I filed, XW-572. In general, the TextProvider never gets properly injected, so this issue is most likely not prevalent. It does seem to effect I18N component, which does the injection itself.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2226) TextProvider.class should not be
registered as a Singleton
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Holmes updated WW-2226:
-----------------------------
Fix Version/s: 2.0.12
> TextProvider.class should not be registered as a Singleton
> ----------------------------------------------------------
>
> Key: WW-2226
> URL: https://issues.apache.org/struts/browse/WW-2226
> Project: Struts 2
> Issue Type: Bug
> Components: API, Configuration
> Affects Versions: 2.0.9
> Reporter: Darren Shepherd
> Fix For: 2.0.12
>
> Attachments: textprovider.patch
>
>
> TextProvider.class should be not registered in the Container as a Singleton. If the TextProvider impl is an instanceof ResourceBundleTextProvider, the TextProviderFactory will call setClazz, and setLocaleProvider on the impl. This is not thread safe. This is related an xwork bug I filed, XW-572. In general, the TextProvider never gets properly injected, so this issue is most likely not prevalent. It does seem to effect I18N component, which does the injection itself.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WW-2226) TextProvider.class should not be
registered as a Singleton
Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Husted reassigned WW-2226:
------------------------------
Assignee: Ted Husted
> TextProvider.class should not be registered as a Singleton
> ----------------------------------------------------------
>
> Key: WW-2226
> URL: https://issues.apache.org/struts/browse/WW-2226
> Project: Struts 2
> Issue Type: Bug
> Components: "New" API, XML Configuration
> Affects Versions: 2.0.9
> Reporter: Darren Shepherd
> Assignee: Ted Husted
> Fix For: 2.1.1
>
> Attachments: textprovider.patch
>
>
> TextProvider.class should be not registered in the Container as a Singleton. If the TextProvider impl is an instanceof ResourceBundleTextProvider, the TextProviderFactory will call setClazz, and setLocaleProvider on the impl. This is not thread safe. This is related an xwork bug I filed, XW-572. In general, the TextProvider never gets properly injected, so this issue is most likely not prevalent. It does seem to effect I18N component, which does the injection itself.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2226) TextProvider.class should not be
registered as a Singleton
Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Husted updated WW-2226:
---------------------------
Flags: [Patch]
Fix Version/s: (was: 2.1.2)
2.1.1
> TextProvider.class should not be registered as a Singleton
> ----------------------------------------------------------
>
> Key: WW-2226
> URL: https://issues.apache.org/struts/browse/WW-2226
> Project: Struts 2
> Issue Type: Bug
> Components: API, Configuration
> Affects Versions: 2.0.9
> Reporter: Darren Shepherd
> Fix For: 2.1.1
>
> Attachments: textprovider.patch
>
>
> TextProvider.class should be not registered in the Container as a Singleton. If the TextProvider impl is an instanceof ResourceBundleTextProvider, the TextProviderFactory will call setClazz, and setLocaleProvider on the impl. This is not thread safe. This is related an xwork bug I filed, XW-572. In general, the TextProvider never gets properly injected, so this issue is most likely not prevalent. It does seem to effect I18N component, which does the injection itself.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2226) TextProvider.class should not be
registered as a Singleton
Posted by "Darren Shepherd (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Darren Shepherd updated WW-2226:
--------------------------------
Attachment: textprovider.patch
Possible fix.
> TextProvider.class should not be registered as a Singleton
> ----------------------------------------------------------
>
> Key: WW-2226
> URL: https://issues.apache.org/struts/browse/WW-2226
> Project: Struts 2
> Issue Type: Bug
> Components: API, Configuration
> Affects Versions: 2.0.9
> Reporter: Darren Shepherd
> Attachments: textprovider.patch
>
>
> TextProvider.class should be not registered in the Container as a Singleton. If the TextProvider impl is an instanceof ResourceBundleTextProvider, the TextProviderFactory will call setClazz, and setLocaleProvider on the impl. This is not thread safe. This is related an xwork bug I filed, XW-572. In general, the TextProvider never gets properly injected, so this issue is most likely not prevalent. It does seem to effect I18N component, which does the injection itself.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WW-2226) TextProvider.class should
not be registered as a Singleton
Posted by "Darren Shepherd (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42320 ]
darren.s.shepherd edited comment on WW-2226 at 10/1/07 9:20 PM:
--------------------------------------------------------------
Possible fix attached
was (Author: darren.s.shepherd):
Possible fix.
> TextProvider.class should not be registered as a Singleton
> ----------------------------------------------------------
>
> Key: WW-2226
> URL: https://issues.apache.org/struts/browse/WW-2226
> Project: Struts 2
> Issue Type: Bug
> Components: API, Configuration
> Affects Versions: 2.0.9
> Reporter: Darren Shepherd
> Attachments: textprovider.patch
>
>
> TextProvider.class should be not registered in the Container as a Singleton. If the TextProvider impl is an instanceof ResourceBundleTextProvider, the TextProviderFactory will call setClazz, and setLocaleProvider on the impl. This is not thread safe. This is related an xwork bug I filed, XW-572. In general, the TextProvider never gets properly injected, so this issue is most likely not prevalent. It does seem to effect I18N component, which does the injection itself.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WW-2226) TextProvider.class should not be
registered as a Singleton
Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Husted resolved WW-2226.
----------------------------
Resolution: Fixed
Completed: At revision: 612799 -- Thanks Darren.
In the description, I assume it meant to read that it does *not* affect i18n.
> TextProvider.class should not be registered as a Singleton
> ----------------------------------------------------------
>
> Key: WW-2226
> URL: https://issues.apache.org/struts/browse/WW-2226
> Project: Struts 2
> Issue Type: Bug
> Components: "New" API, XML Configuration
> Affects Versions: 2.0.9
> Reporter: Darren Shepherd
> Assignee: Ted Husted
> Fix For: 2.1.1
>
> Attachments: textprovider.patch
>
>
> TextProvider.class should be not registered in the Container as a Singleton. If the TextProvider impl is an instanceof ResourceBundleTextProvider, the TextProviderFactory will call setClazz, and setLocaleProvider on the impl. This is not thread safe. This is related an xwork bug I filed, XW-572. In general, the TextProvider never gets properly injected, so this issue is most likely not prevalent. It does seem to effect I18N component, which does the injection itself.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.