You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ma...@apache.org on 2012/01/24 17:26:06 UTC

[1/3] git commit: CB-199: FileTransfer.download fails on Android 4.0

Updated Branches:
  refs/heads/master e8544d30d -> 89e260a5a


CB-199: FileTransfer.download fails on Android 4.0

The download method in FileTransfer was setting the HttpURLConnection.setDoOutput to true. On Android 4.0 this would force the connection to be a POST when what we actually want is a GET.

I removed the offending line and tested the fix in 2.1, 2.2, 2.3 and 4.0.


Project: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/commit/89e260a5
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/tree/89e260a5
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/diff/89e260a5

Branch: refs/heads/master
Commit: 89e260a5a1ffa35cf9ff6563fe83883f186e40b2
Parents: 6e5ef1e
Author: macdonst <si...@gmail.com>
Authored: Tue Jan 24 11:23:41 2012 -0500
Committer: macdonst <si...@gmail.com>
Committed: Tue Jan 24 11:24:06 2012 -0500

----------------------------------------------------------------------
 framework/src/com/phonegap/FileTransfer.java |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/blob/89e260a5/framework/src/com/phonegap/FileTransfer.java
----------------------------------------------------------------------
diff --git a/framework/src/com/phonegap/FileTransfer.java b/framework/src/com/phonegap/FileTransfer.java
index 0c3132f..a75f768 100644
--- a/framework/src/com/phonegap/FileTransfer.java
+++ b/framework/src/com/phonegap/FileTransfer.java
@@ -54,7 +54,7 @@ import com.phonegap.api.PluginResult;
 
 public class FileTransfer extends Plugin {
 
-    private static final String LOG_TAG = "FileUploader";
+    private static final String LOG_TAG = "FileTransfer";
     private static final String LINE_START = "--";
     private static final String LINE_END = "\r\n";
     private static final String BOUNDRY =  "*****";
@@ -386,7 +386,6 @@ public class FileTransfer extends Plugin {
             URL url = new URL(source);
             HttpURLConnection connection = (HttpURLConnection) url.openConnection();
             connection.setRequestMethod("GET");
-            connection.setDoOutput(true);
             connection.connect();
 
             Log.d(LOG_TAG, "Download file:" + url);