[GitHub] [incubator-pinot] harleyjj commented on a change in pull request #5740: [TE] Added a backfill start date for Anomaly Detection

[GitBox <gi...@apache.org>]

harleyjj commented on a change in pull request #5740:
URL: https://github.com/apache/incubator-pinot/pull/5740#discussion_r459688843



##########
File path: thirdeye/thirdeye-frontend/app/utils/yaml-tools.js
##########
@@ -12,12 +12,11 @@ dataset: dataset_to_which_this_metric_belongs
 rules:
 - detection:
   - name: detection_rule_1
-    type: ALGORITHM             # Configure the detection type here. See doc for more details.
+    type: PERCENTAGE_RULE       # Configure the detection type here. See doc for more details.

Review comment:
       I think we can move these templates into the environment.js file [here](https://github.com/apache/incubator-pinot/blob/master/thirdeye/thirdeye-frontend/config/environment.js) and then different users can configure their own default templates for detection and subscription group yaml configurations.  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org