You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/02/20 20:03:37 UTC
[GitHub] [maven] cstamas opened a new pull request #449: Make VersionScheme a component
cstamas opened a new pull request #449:
URL: https://github.com/apache/maven/pull/449
Instead to ad-hoc create the instance as needed, it is thread safe,
so is fine to have it shared across whole system.
Moreover, touched classes got converted from ancient plexus-field-like
injection to proper immutable components, something we really need
start doing.
Full conversion (of resolver classes) will become possible once ServiceLocator dropped
(see MRESOLVER-157).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #449: [MNG-7103] Make VersionScheme a component
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #449:
URL: https://github.com/apache/maven/pull/449#discussion_r624725182
##########
File path: maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/VersionSchemeProvider.java
##########
@@ -0,0 +1,49 @@
+package org.apache.maven.repository.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.eclipse.aether.util.version.GenericVersionScheme;
+import org.eclipse.aether.version.VersionScheme;
+
+import javax.inject.Named;
+import javax.inject.Provider;
+import javax.inject.Singleton;
+
+/**
+ * Provider of {@link org.eclipse.aether.util.version.GenericVersionScheme}.
+ */
+@Named
+@Singleton
+public class VersionSchemeProvider
Review comment:
Why do we need this provider? Where is it used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #449: [MNG-7103] Make VersionScheme a component
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #449:
URL: https://github.com/apache/maven/pull/449#discussion_r624725182
##########
File path: maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/VersionSchemeProvider.java
##########
@@ -0,0 +1,49 @@
+package org.apache.maven.repository.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.eclipse.aether.util.version.GenericVersionScheme;
+import org.eclipse.aether.version.VersionScheme;
+
+import javax.inject.Named;
+import javax.inject.Provider;
+import javax.inject.Singleton;
+
+/**
+ * Provider of {@link org.eclipse.aether.util.version.GenericVersionScheme}.
+ */
+@Named
+@Singleton
+public class VersionSchemeProvider
Review comment:
Why do we need this provider If `GenericVersionScheme` is properly annotated? Where is it used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas closed pull request #449: [MNG-7103] Make VersionScheme a component
Posted by GitBox <gi...@apache.org>.
cstamas closed pull request #449:
URL: https://github.com/apache/maven/pull/449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #449: [MNG-7103] Make VersionScheme a component
Posted by GitBox <gi...@apache.org>.
cstamas commented on pull request #449:
URL: https://github.com/apache/maven/pull/449#issuecomment-932948071
Obsolete, replaced by https://github.com/apache/maven/pull/563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on a change in pull request #449: [MNG-7103] Make VersionScheme a component
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #449:
URL: https://github.com/apache/maven/pull/449#discussion_r624726448
##########
File path: maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/VersionSchemeProvider.java
##########
@@ -0,0 +1,49 @@
+package org.apache.maven.repository.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.eclipse.aether.util.version.GenericVersionScheme;
+import org.eclipse.aether.version.VersionScheme;
+
+import javax.inject.Named;
+import javax.inject.Provider;
+import javax.inject.Singleton;
+
+/**
+ * Provider of {@link org.eclipse.aether.util.version.GenericVersionScheme}.
+ */
+@Named
+@Singleton
+public class VersionSchemeProvider
Review comment:
Need to review this and refresh my memory. But the idea was to have some sort of indirection, if we want to introduce other kind than "generic" version support... Consider this PR as draft pls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org