You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Eli Collins (Created) (JIRA)" <ji...@apache.org> on 2012/01/25 03:48:41 UTC
[jira] [Created] (HADOOP-7991) HA: the FailoverController should
check the standby is ready before failing over
HA: the FailoverController should check the standby is ready before failing over
--------------------------------------------------------------------------------
Key: HADOOP-7991
URL: https://issues.apache.org/jira/browse/HADOOP-7991
Project: Hadoop Common
Issue Type: Sub-task
Components: ha
Affects Versions: HA Branch (HDFS-1623)
Reporter: Eli Collins
Assignee: Eli Collins
The FC in preFailoverChecks should check that the target service is ready for failover (eg in the case of HDFS, that it's not in SM) before failing over to it. We'll need to provide a force option as well since the standby may not actually be ready until the failover has been initiated (eg because becoming active kicks it to check the log and see newly allocated blocks).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7991) HA: the FailoverController should
check the standby is ready before failing over
Posted by "Eli Collins (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199124#comment-13199124 ]
Eli Collins commented on HADOOP-7991:
-------------------------------------
I've committed this. Thanks for the review Todd.
> HA: the FailoverController should check the standby is ready before failing over
> --------------------------------------------------------------------------------
>
> Key: HADOOP-7991
> URL: https://issues.apache.org/jira/browse/HADOOP-7991
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ha
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hadoop-7991.txt
>
>
> The FC in preFailoverChecks should check that the target service is ready for failover (eg in the case of HDFS, that it's not in SM) before failing over to it. We'll need to provide a force option as well since the standby may not actually be ready until the failover has been initiated (eg because becoming active kicks it to check the log and see newly allocated blocks).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7991) HA: the FailoverController should
check the standby is ready before failing over
Posted by "Eli Collins (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-7991:
--------------------------------
Attachment: hadoop-7991.txt
Patch attached.
> HA: the FailoverController should check the standby is ready before failing over
> --------------------------------------------------------------------------------
>
> Key: HADOOP-7991
> URL: https://issues.apache.org/jira/browse/HADOOP-7991
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ha
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hadoop-7991.txt
>
>
> The FC in preFailoverChecks should check that the target service is ready for failover (eg in the case of HDFS, that it's not in SM) before failing over to it. We'll need to provide a force option as well since the standby may not actually be ready until the failover has been initiated (eg because becoming active kicks it to check the log and see newly allocated blocks).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7991) HA: the FailoverController should
check the standby is ready before failing over
Posted by "Eli Collins (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199108#comment-13199108 ]
Eli Collins commented on HADOOP-7991:
-------------------------------------
Yea, I tested putting the SBN in SM, failover, which fails, then failover with forceactive which succeeds even though the SBN is still in SM.
{noformat}
hadoop-0.24.0-SNAPSHOT $ ./bin/hdfs dfsadmin -fs hdfs://localhost:8022 -safemode enter
Safe mode is ON
hadoop-0.24.0-SNAPSHOT $ ./bin/hdfs haadmin -failover localhost:8021 localhost:8022
Failover failed: localhost/127.0.0.1:8022 is not ready to become active
hadoop-0.24.0-SNAPSHOT $ ./bin/hdfs haadmin -failover localhost:8021 localhost:8022 --forceactive
Failover from localhost:8021 to localhost:8022 successful
hadoop-0.24.0-SNAPSHOT $ /bin/hdfs dfsadmin -fs hdfs://localhost:8022 -safemode get
Safe mode is ON
{noformat}
> HA: the FailoverController should check the standby is ready before failing over
> --------------------------------------------------------------------------------
>
> Key: HADOOP-7991
> URL: https://issues.apache.org/jira/browse/HADOOP-7991
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ha
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hadoop-7991.txt
>
>
> The FC in preFailoverChecks should check that the target service is ready for failover (eg in the case of HDFS, that it's not in SM) before failing over to it. We'll need to provide a force option as well since the standby may not actually be ready until the failover has been initiated (eg because becoming active kicks it to check the log and see newly allocated blocks).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7991) HA: the FailoverController should
check the standby is ready before failing over
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199690#comment-13199690 ]
Hudson commented on HADOOP-7991:
--------------------------------
Integrated in Hadoop-Hdfs-HAbranch-build #67 (See [https://builds.apache.org/job/Hadoop-Hdfs-HAbranch-build/67/])
HADOOP-7991. HA: the FailoverController should check the standby is ready before failing over. Contributed by Eli Collins
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1239774
Files :
* /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/CHANGES.HDFS-1623.txt
* /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/FailoverController.java
* /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAAdmin.java
* /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAServiceProtocol.java
* /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestFailoverController.java
* /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestHAAdmin.java
* /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
* /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
> HA: the FailoverController should check the standby is ready before failing over
> --------------------------------------------------------------------------------
>
> Key: HADOOP-7991
> URL: https://issues.apache.org/jira/browse/HADOOP-7991
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ha
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hadoop-7991.txt
>
>
> The FC in preFailoverChecks should check that the target service is ready for failover (eg in the case of HDFS, that it's not in SM) before failing over to it. We'll need to provide a force option as well since the standby may not actually be ready until the failover has been initiated (eg because becoming active kicks it to check the log and see newly allocated blocks).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HADOOP-7991) HA: the FailoverController should
check the standby is ready before failing over
Posted by "Todd Lipcon (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon resolved HADOOP-7991.
---------------------------------
Resolution: Fixed
Fix Version/s: HA Branch (HDFS-1623)
Hadoop Flags: Reviewed
Eli committed this yesterday, but was having JIRA problems. Resolving on his behalf.
> HA: the FailoverController should check the standby is ready before failing over
> --------------------------------------------------------------------------------
>
> Key: HADOOP-7991
> URL: https://issues.apache.org/jira/browse/HADOOP-7991
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ha
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: HA Branch (HDFS-1623)
>
> Attachments: hadoop-7991.txt
>
>
> The FC in preFailoverChecks should check that the target service is ready for failover (eg in the case of HDFS, that it's not in SM) before failing over to it. We'll need to provide a force option as well since the standby may not actually be ready until the failover has been initiated (eg because becoming active kicks it to check the log and see newly allocated blocks).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7991) HA: the FailoverController should
check the standby is ready before failing over
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198189#comment-13198189 ]
Todd Lipcon commented on HADOOP-7991:
-------------------------------------
Looks good to me. Did you test the command line on a cluster?
> HA: the FailoverController should check the standby is ready before failing over
> --------------------------------------------------------------------------------
>
> Key: HADOOP-7991
> URL: https://issues.apache.org/jira/browse/HADOOP-7991
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ha
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hadoop-7991.txt
>
>
> The FC in preFailoverChecks should check that the target service is ready for failover (eg in the case of HDFS, that it's not in SM) before failing over to it. We'll need to provide a force option as well since the standby may not actually be ready until the failover has been initiated (eg because becoming active kicks it to check the log and see newly allocated blocks).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira