You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/09/13 02:00:52 UTC
[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #7242: [IOTDB-3184] Implement Delete Timeseries for Cluster
MarcosZyk commented on code in PR #7242:
URL: https://github.com/apache/iotdb/pull/7242#discussion_r969070883
##########
confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/DeleteTimeSeriesProcedure.java:
##########
@@ -0,0 +1,611 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.confignode.procedure.impl;
+
+import org.apache.iotdb.common.rpc.thrift.TConsensusGroupId;
+import org.apache.iotdb.common.rpc.thrift.TDataNodeLocation;
+import org.apache.iotdb.common.rpc.thrift.TRegionReplicaSet;
+import org.apache.iotdb.common.rpc.thrift.TSStatus;
+import org.apache.iotdb.commons.path.PartialPath;
+import org.apache.iotdb.confignode.client.async.datanode.AsyncDataNodeClientPool;
+import org.apache.iotdb.confignode.client.async.handlers.ConstructSchemaBlackListHandler;
+import org.apache.iotdb.confignode.client.async.handlers.DeleteDataForDeleteTimeSeriesHandler;
+import org.apache.iotdb.confignode.client.async.handlers.DeleteTimeSeriesHandler;
+import org.apache.iotdb.confignode.client.async.handlers.FetchSchemaBlackLsitHandler;
+import org.apache.iotdb.confignode.client.async.handlers.InvalidateMatchedSchemaCacheHandler;
+import org.apache.iotdb.confignode.client.async.handlers.RollbackSchemaBlackListHandler;
+import org.apache.iotdb.confignode.procedure.StateMachineProcedure;
+import org.apache.iotdb.confignode.procedure.env.ConfigNodeProcedureEnv;
+import org.apache.iotdb.confignode.procedure.exception.ProcedureException;
+import org.apache.iotdb.confignode.procedure.exception.ProcedureSuspendedException;
+import org.apache.iotdb.confignode.procedure.exception.ProcedureYieldException;
+import org.apache.iotdb.confignode.procedure.state.DeleteTimeSeriesState;
+import org.apache.iotdb.confignode.procedure.store.ProcedureFactory;
+import org.apache.iotdb.db.exception.metadata.PathNotExistException;
+import org.apache.iotdb.db.mpp.common.schematree.PathPatternTree;
+import org.apache.iotdb.mpp.rpc.thrift.TConstructSchemaBlackListReq;
+import org.apache.iotdb.mpp.rpc.thrift.TDeleteDataForDeleteTimeSeriesReq;
+import org.apache.iotdb.mpp.rpc.thrift.TDeleteTimeSeriesReq;
+import org.apache.iotdb.mpp.rpc.thrift.TFetchSchemaBlackListReq;
+import org.apache.iotdb.mpp.rpc.thrift.TFetchSchemaBlackListResp;
+import org.apache.iotdb.mpp.rpc.thrift.TInvalidateMatchedSchemaCacheReq;
+import org.apache.iotdb.mpp.rpc.thrift.TRollbackSchemaBlackListReq;
+import org.apache.iotdb.rpc.TSStatusCode;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.ByteArrayOutputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.stream.Collectors;
+
+public class DeleteTimeSeriesProcedure
+ extends StateMachineProcedure<ConfigNodeProcedureEnv, DeleteTimeSeriesState> {
+
+ private static final Logger LOGGER = LoggerFactory.getLogger(DeleteTimeSeriesProcedure.class);
+
+ private PathPatternTree patternTree;
+ private ByteBuffer patternTreeBytes;
+
+ private String requestMessage;
+
+ public DeleteTimeSeriesProcedure() {
+ super();
+ }
+
+ public DeleteTimeSeriesProcedure(PathPatternTree patternTree) {
+ super();
+ setPatternTree(patternTree);
+ }
+
+ @Override
+ protected Flow executeFromState(ConfigNodeProcedureEnv env, DeleteTimeSeriesState state)
+ throws ProcedureSuspendedException, ProcedureYieldException, InterruptedException {
+ switch (state) {
+ case CONSTRUCT_BLACK_LIST:
+ LOGGER.info("Construct schema black list of timeseries {}", requestMessage);
+ if (constructBlackList(env) > 0) {
+ setNextState(DeleteTimeSeriesState.CLEAN_DATANODE_SCHEMA_CACHE);
+ break;
+ } else {
+ setFailure(
+ new ProcedureException(
+ new PathNotExistException(
+ patternTree.getAllPathPatterns().stream()
+ .map(PartialPath::getFullPath)
+ .collect(Collectors.toList()))));
+ return Flow.NO_MORE_STATE;
+ }
+ case CLEAN_DATANODE_SCHEMA_CACHE:
+ LOGGER.info("Invalidate cache of timeseries {}", requestMessage);
+ invalidateCache(env);
+ break;
+ case DELETE_DATA:
+ LOGGER.info("Delete data of timeseries {}", requestMessage);
+ deleteData(env);
+ break;
+ case DELETE_TIMESERIES:
+ LOGGER.info("Delete timeseries schema of {}", requestMessage);
+ deleteTimeSeries(env);
+ return Flow.NO_MORE_STATE;
+ default:
+ setFailure(new ProcedureException("Unrecognized state " + state.toString()));
+ return Flow.NO_MORE_STATE;
+ }
+ return Flow.HAS_MORE_STATE;
+ }
+
+ private int constructBlackList(ConfigNodeProcedureEnv env) {
+ Map<TConsensusGroupId, TRegionReplicaSet> targetSchemaRegionGroup =
+ env.getConfigManager().getRelatedSchemaRegionGroup(patternTree);
+ if (targetSchemaRegionGroup.isEmpty()) {
+ return 0;
+ }
+ RegionTask<TSStatus> constructBlackListTask =
+ new RegionTask<TSStatus>("construct schema black list", env, targetSchemaRegionGroup) {
+ @Override
+ Map<Integer, TSStatus> sendRequest(
+ TDataNodeLocation dataNodeLocation, List<TConsensusGroupId> consensusGroupIdList) {
+ // construct request and send
+ Map<Integer, TDataNodeLocation> dataNodeLocationMap = new HashMap<>();
+ dataNodeLocationMap.put(dataNodeLocation.getDataNodeId(), dataNodeLocation);
+ ConstructSchemaBlackListHandler handler =
+ new ConstructSchemaBlackListHandler(dataNodeLocationMap);
+ AsyncDataNodeClientPool.getInstance()
+ .sendAsyncRequestToDataNodeWithRetry(
+ new TConstructSchemaBlackListReq(consensusGroupIdList, patternTreeBytes),
+ handler);
+ handler
+ .getDataNodeResponseStatusMap()
+ .forEach(
+ (k, v) -> {
+ if (v.getCode() == TSStatusCode.SUCCESS_STATUS.getStatusCode()) {
+ responseMap.put(k, v);
+ }
+ });
+ return handler.getDataNodeResponseStatusMap();
+ }
+ };
+ constructBlackListTask.execute();
+
+ if (isFailed()) {
+ return 0;
+ }
+
+ int preDeletedNum = 0;
+ for (TSStatus resp : constructBlackListTask.getResponseMap().values()) {
+ preDeletedNum += Integer.parseInt(resp.getMessage());
+ }
+ return preDeletedNum;
+ }
+
+ private void invalidateCache(ConfigNodeProcedureEnv env) {
+ Map<Integer, TDataNodeLocation> dataNodeLocationMap =
+ env.getConfigManager().getNodeManager().getRegisteredDataNodeLocations();
+ InvalidateMatchedSchemaCacheHandler handler =
+ new InvalidateMatchedSchemaCacheHandler(dataNodeLocationMap);
+ AsyncDataNodeClientPool.getInstance()
+ .sendAsyncRequestToDataNodeWithRetry(
+ new TInvalidateMatchedSchemaCacheReq(patternTreeBytes), handler);
+ Map<Integer, TSStatus> statusMap = handler.getDataNodeResponseStatusMap();
+ for (TSStatus status : statusMap.values()) {
+ // all dataNodes must clear the related schema cache
+ if (status.getCode() != TSStatusCode.SUCCESS_STATUS.getStatusCode()) {
+ LOGGER.error("Failed to invalidate schema cache of timeseries {}", requestMessage);
+ setFailure(new ProcedureException("Invalidate schema cache failed"));
+ return;
+ }
+ }
+
+ setNextState(DeleteTimeSeriesState.DELETE_DATA);
+ }
+
+ private void deleteData(ConfigNodeProcedureEnv env) {
+ Map<TConsensusGroupId, TRegionReplicaSet> relatedSchemaRegionGroup =
+ env.getConfigManager().getRelatedSchemaRegionGroup(patternTree);
+ Map<TDataNodeLocation, List<TConsensusGroupId>> dataNodeSchemaRegionGroupGroupIdMap =
+ getLeaderDataNodeRegionGroupMap(
+ env.getConfigManager().getPartitionManager().getAllLeadership(),
+ relatedSchemaRegionGroup);
+
+ // fetch schema black list by dataNode
+ for (Map.Entry<TDataNodeLocation, List<TConsensusGroupId>> entry :
+ dataNodeSchemaRegionGroupGroupIdMap.entrySet()) {
+ Map<TConsensusGroupId, TRegionReplicaSet> targetSchemaRegionGroup = new HashMap<>();
+ entry
+ .getValue()
+ .forEach(
+ consensusGroupId ->
+ targetSchemaRegionGroup.put(
+ consensusGroupId, relatedSchemaRegionGroup.get(consensusGroupId)));
+ PathPatternTree patternTree =
+ fetchSchemaBlackListOnTargetDataNode(env, targetSchemaRegionGroup);
+ if (isFailed()) {
+ return;
+ }
+ if (patternTree == null) {
+ LOGGER.error(
+ "Failed to fetch schema black list for delete data of timeseries {} on {}",
+ requestMessage,
+ entry.getKey());
+ setFailure(new ProcedureException("Fetch schema black list forDelete data failed"));
+ return;
+ }
+
+ if (patternTree.isEmpty()) {
+ continue;
+ }
+
+ Map<TConsensusGroupId, TRegionReplicaSet> relatedDataRegionGroup =
+ env.getConfigManager().getRelatedDataRegionGroup(patternTree);
+
+ // target timeseries has no data
+ if (relatedDataRegionGroup.isEmpty()) {
+ continue;
+ }
+
+ RegionTask<TSStatus> deleteDataTask =
+ new RegionTask<TSStatus>("delete data", env, relatedDataRegionGroup) {
+ @Override
+ Map<Integer, TSStatus> sendRequest(
+ TDataNodeLocation dataNodeLocation, List<TConsensusGroupId> consensusGroupIdList) {
+ Map<Integer, TDataNodeLocation> dataNodeLocationMap = new HashMap<>();
+ dataNodeLocationMap.put(dataNodeLocation.getDataNodeId(), dataNodeLocation);
+ DeleteDataForDeleteTimeSeriesHandler handler =
+ new DeleteDataForDeleteTimeSeriesHandler(dataNodeLocationMap);
+ AsyncDataNodeClientPool.getInstance()
+ .sendAsyncRequestToDataNodeWithRetry(
+ new TDeleteDataForDeleteTimeSeriesReq(
+ new ArrayList<>(consensusGroupIdList),
+ preparePatternTreeBytesData(patternTree)),
+ handler);
+ return handler.getDataNodeResponseStatusMap();
+ }
+ };
+ deleteDataTask.setExecuteOnAllReplicaset(true);
+ deleteDataTask.execute();
+ if (isFailed()) {
+ return;
+ }
+ }
+ setNextState(DeleteTimeSeriesState.DELETE_TIMESERIES);
+ }
+
+ private PathPatternTree fetchSchemaBlackListOnTargetDataNode(
+ ConfigNodeProcedureEnv env,
+ Map<TConsensusGroupId, TRegionReplicaSet> targetSchemaRegionGroup) {
+ RegionTask<TFetchSchemaBlackListResp> fetchSchemaBlackListTask =
+ new RegionTask<TFetchSchemaBlackListResp>(
+ "fetch schema black list", env, targetSchemaRegionGroup) {
+ @Override
+ Map<Integer, TSStatus> sendRequest(
+ TDataNodeLocation dataNodeLocation, List<TConsensusGroupId> consensusGroupIdList) {
+ Map<Integer, TDataNodeLocation> dataNodeLocationMap = new HashMap<>();
+ dataNodeLocationMap.put(dataNodeLocation.getDataNodeId(), dataNodeLocation);
+ FetchSchemaBlackLsitHandler handler =
+ new FetchSchemaBlackLsitHandler(dataNodeLocationMap);
+ AsyncDataNodeClientPool.getInstance()
+ .sendAsyncRequestToDataNodeWithRetry(
+ new TFetchSchemaBlackListReq(consensusGroupIdList, patternTreeBytes), handler);
+ Map<Integer, TFetchSchemaBlackListResp> respMap = handler.getDataNodeResponseMap();
+ Map<Integer, TSStatus> statusMap = new HashMap<>();
+ respMap.forEach(
+ (k, v) -> {
+ if (v.getStatus().getCode() == TSStatusCode.SUCCESS_STATUS.getStatusCode()) {
+ responseMap.put(k, v);
+ }
+ statusMap.put(k, v.getStatus());
+ });
+ return statusMap;
+ }
+ };
+ fetchSchemaBlackListTask.execute();
+ if (isFailed()) {
+ return null;
+ }
+
+ Map<Integer, TFetchSchemaBlackListResp> respMap = fetchSchemaBlackListTask.getResponseMap();
+ PathPatternTree patternTree = new PathPatternTree();
+ for (TFetchSchemaBlackListResp resp : respMap.values()) {
+ for (PartialPath path :
+ PathPatternTree.deserialize(ByteBuffer.wrap(resp.getPathPatternTree()))
+ .getAllPathPatterns()) {
+ patternTree.appendPathPattern(path);
+ }
+ }
+ patternTree.constructTree();
+ return patternTree;
+ }
+
+ private void deleteTimeSeries(ConfigNodeProcedureEnv env) {
+ RegionTask<TSStatus> deleteTimeSeriesTask =
+ new RegionTask<TSStatus>(
+ "delete timeseries",
+ env,
+ env.getConfigManager().getRelatedSchemaRegionGroup(patternTree)) {
+ @Override
+ Map<Integer, TSStatus> sendRequest(
+ TDataNodeLocation dataNodeLocation, List<TConsensusGroupId> consensusGroupIdList) {
+ Map<Integer, TDataNodeLocation> dataNodeLocationMap = new HashMap<>();
+ dataNodeLocationMap.put(dataNodeLocation.getDataNodeId(), dataNodeLocation);
+ DeleteTimeSeriesHandler handler = new DeleteTimeSeriesHandler(dataNodeLocationMap);
+ AsyncDataNodeClientPool.getInstance()
+ .sendAsyncRequestToDataNodeWithRetry(
+ new TDeleteTimeSeriesReq(consensusGroupIdList, patternTreeBytes), handler);
+ return handler.getDataNodeResponseStatusMap();
+ }
+ };
+ deleteTimeSeriesTask.execute();
+ }
+
+ private Map<TDataNodeLocation, List<TConsensusGroupId>> getLeaderDataNodeRegionGroupMap(
+ Map<TConsensusGroupId, Integer> leaderMap,
+ Map<TConsensusGroupId, TRegionReplicaSet> regionReplicaSetMap) {
+ Map<TDataNodeLocation, List<TConsensusGroupId>> dataNodeConsensusGroupIdMap = new HashMap<>();
+ regionReplicaSetMap.forEach(
+ (consensusGroupId, regionReplicaSet) -> {
+ Integer leaderId = leaderMap.get(consensusGroupId);
+ TDataNodeLocation leaderDataNodeLocation = null;
+ if (leaderId == null || leaderId == -1) {
+ leaderDataNodeLocation = regionReplicaSet.getDataNodeLocations().get(0);
+ } else {
+ for (TDataNodeLocation dataNodeLocation : regionReplicaSet.getDataNodeLocations()) {
+ if (dataNodeLocation.getDataNodeId() == leaderId) {
+ leaderDataNodeLocation = dataNodeLocation;
+ break;
+ }
+ }
+ }
+ dataNodeConsensusGroupIdMap
+ .computeIfAbsent(leaderDataNodeLocation, k -> new ArrayList<>())
+ .add(regionReplicaSet.getRegionId());
+ });
+ return dataNodeConsensusGroupIdMap;
+ }
+
+ private Map<TDataNodeLocation, List<TConsensusGroupId>> getAllReplicaDataNodeRegionGroupMap(
+ Map<TConsensusGroupId, TRegionReplicaSet> regionReplicaSetMap) {
+ Map<TDataNodeLocation, List<TConsensusGroupId>> dataNodeConsensusGroupIdMap = new HashMap<>();
+ regionReplicaSetMap.forEach(
+ (consensusGroupId, regionReplicaSet) -> {
+ for (TDataNodeLocation dataNodeLocation : regionReplicaSet.getDataNodeLocations()) {
+ dataNodeConsensusGroupIdMap
+ .computeIfAbsent(dataNodeLocation, k -> new ArrayList<>())
+ .add(regionReplicaSet.getRegionId());
+ }
+ });
+ return dataNodeConsensusGroupIdMap;
+ }
+
+ @Override
+ protected void rollbackState(
+ ConfigNodeProcedureEnv env, DeleteTimeSeriesState deleteTimeSeriesState)
+ throws IOException, InterruptedException, ProcedureException {
+ RegionTask<TSStatus> rollbackStateTask =
+ new RegionTask<TSStatus>(
+ "roll back schema black list",
+ env,
Review Comment:
Since schema black list is constructed before all states, it must be rollback to make related timeseries usable again, when any state failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org