You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by vladimir-kotikov <gi...@git.apache.org> on 2016/02/09 16:14:33 UTC
[GitHub] cordova-lib pull request: CB-10430 Adds forwardEvents method to ea...
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/382
CB-10430 Adds forwardEvents method to easily connect two EventEmitters
This fixes CB-10430.
This change is needed to allow platform connect own `events` instance to another, provided by caller (`cordova-lib` in most cases)
This PR is a replacement for #370
A usage sample:
```javascript
function Api(platform, platformRootDir, eventEmitter) {
...
if (eventEmitter) {
events.forwardEventsTo(eventEmitter);
} else {
CordovaLogger.get().subscribe(events);
}
...
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-10430
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/382.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #382
----
commit 426e3a9e15b6c32c67f1173b8b71e8d6ba551b45
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2016-02-09T06:26:52Z
CB-10430 Adds forwardEvents method to easily connect two EventEmitters
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10430 Adds forwardEvents method to ea...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/382#issuecomment-181964075
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10430 Adds forwardEvents method to ea...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/382#issuecomment-181910107
@nikhilkh, could you please take a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10430 Adds forwardEvents method to ea...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/382
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org