[PATCH] Berkeley DB and Windows CRT Issue

[Russell Yanofsky <re...@columbia.edu>]

Log Message:

Small change to the fs library which prevents the heap corruption that
otherwise occurs when Subversion and Berkeley DB modules use different C
runtime libraries. This change should eliminate the need to distribute
separate builds of Berkeley DB for VC6 and VC7 on Windows.

* subversion/libsvn_fs/fs.c (allocate_env): Changed to call set_alloc() on
  each new Berkeley DB environment object.


begin 666 heap.diff
M26YD97@Z('-U8G9E<G-I;VXO;&EB<W9N7V9S+V9S+F,*/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/0HM+2T@<W5B=F5R<VEO;B]L:6)S=FY?9G,O9G,N8PDH<F5V
M:7-I;VX@-C(R,2D**RLK('-U8G9E<G-I;VXO;&EB<W9N7V9S+V9S+F,)*'=O
M<FMI;F<@8V]P>2D*0$ @+3,T,2PV("LS-#$L,3$@0$ *(" @4U9.7T524B H
M0D1"7U=205 @*&9S+" B86QL;V-A=&EN9R!E;G9I<F]N;65N="!O8FIE8W0B
M+ H@(" @(" @(" @(" @(" @(" @("!D8E]E;G9?8W)E871E("@F9G,M/F5N
M=BP@,"DI*3L*( HK(" O*B!.965D960@;VX@5VEN9&]W<R!I;B!C87-E(%-U
M8G9E<G-I;VX@86YD($)E<FME;&5Y($1"(&%R92!U<VEN9PHK(" @("!D:69F
M97)E;G0@0R!R=6YT:6UE(&QI8G)A<FEE<R @*B\**R @4U9.7T524B H0D1"
M7U=205 @*&9S+" B<V5T=&EN9R!E;G9I<F]N;65N="!O8FIE8W0G<R!A;&QO
M8V%T:6]N(&9U;F-T:6]N<R(L"BL@(" @(" @(" @(" @(" @(" @(&9S+3YE
M;G8M/G-E=%]A;&QO8R H9G,M/F5N=BP@)FUA;&QO8RP@)G)E86QL;V,L("9F
M<F5E*2DI.PHK"B @("\J($EF('=E(&1E=&5C="!A(&1E861L;V-K+"!S96QE
M8W0@82!T<F%N<V%C=&EO;B!T;R!A8F]R="!A="!R86YD;VT*(" @(" @9G)O
M;2!T:&]S92!P87)T:6-I<&%T:6YG(&EN('1H92!D96%D;&]C:RX@("HO"B @
M(%-63E]%4E(@*$)$0E]74D%0("AF<RP@(G-E='1I;F<@9&5A9&QO8VL@9&5T
096-T:6]N('!O;&EC>2(L"@``
`
end



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Berkeley DB and Windows CRT Issue

[Branko Čibej <br...@xbc.nu>]

Russell Yanofsky wrote:

>Log Message:
>
>Small change to the fs library which prevents the heap corruption that
>otherwise occurs when Subversion and Berkeley DB modules use different C
>runtime libraries. This change should eliminate the need to distribute
>separate builds of Berkeley DB for VC6 and VC7 on Windows.
>
>* subversion/libsvn_fs/fs.c (allocate_env): Changed to call set_alloc() on
>  each new Berkeley DB environment object.
>  
>
Good idea! I suspect this will work even once we start generating DLLs,
since all the memory blocks allocated by BDB should be freed inside
libsvn_fs.

By the way, you don't have to take the address of a function; function
names are implicitly converted to function pointers in parameters.
Committed with this change in revision 6256.

(BTW, Purify is happy with this change, too, it reported som other
problems in fs-test.)


-- 
Brane Čibej   <br...@xbc.nu>   http://www.xbc.nu/brane/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org