You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/31 02:41:48 UTC

[GitHub] [doris] dataroaring commented on a diff in pull request #13737: [feature](running_difference) support running_difference function

dataroaring commented on code in PR #13737:
URL: https://github.com/apache/doris/pull/13737#discussion_r1008988110


##########
be/src/vec/functions/function_running_difference.cpp:
##########
@@ -0,0 +1,13 @@
+#include "vec/functions/function_running_difference.h"
+
+namespace doris::vectorized {
+
+void register_function_running_difference(SimpleFunctionFactory& factory) {
+    //factory.register_function<FunctionRunningDifferenceImpl<false>>();
+    factory.register_function<FunctionRunningDifference>();
+    //factory.register_function<FunctionCase<false, true>>();
+    //factory.register_function<FunctionCase<true, false>>();
+    //factory.register_function<FunctionCase<true, true>>();

Review Comment:
   Please remove useless comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org