You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/17 12:15:52 UTC

[GitHub] [arrow] franksmithxyz opened a new pull request #8692: ARROW-10337: [C++] More liberal parsing of ISO8601 timestamps with fractional seconds

franksmithxyz opened a new pull request #8692:
URL: https://github.com/apache/arrow/pull/8692


   The current ISO8601 timestamp parser assumes MILLI timestamps have 3 decimal places, MICRO have 6 and NANO have 9. 
   
   This patch change the parser to accept 1 to 3 digits for MILLI, 1 to 6 digits for MICRO, and 1 to 9 digits for NANO. This allows for parsing of timestamps when e.g. a CSV file does not write timestamps with trailing zeroes. See comments in ParseTimestampISO8601 for details of format.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on pull request #8692: ARROW-10337: [C++] More liberal parsing of ISO8601 timestamps with fractional seconds

Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8692:
URL: https://github.com/apache/arrow/pull/8692#issuecomment-739845074


   Thank for doing this @franksmithxyz . I will merge this if CI becomes green.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on pull request #8692: ARROW-10337: [C++] More liberal parsing of ISO8601 timestamps with fractional seconds

Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8692:
URL: https://github.com/apache/arrow/pull/8692#issuecomment-739833130


   I rebased and fixed the remaining issues.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #8692: ARROW-10337: [C++] More liberal parsing of ISO8601 timestamps with fractional seconds

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8692:
URL: https://github.com/apache/arrow/pull/8692#issuecomment-728897896


   https://issues.apache.org/jira/browse/ARROW-10337


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou closed pull request #8692: ARROW-10337: [C++] More liberal parsing of ISO8601 timestamps with fractional seconds

Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #8692:
URL: https://github.com/apache/arrow/pull/8692


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on pull request #8692: ARROW-10337: [C++] More liberal parsing of ISO8601 timestamps with fractional seconds

Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8692:
URL: https://github.com/apache/arrow/pull/8692#issuecomment-733062570


   Thanks for doing this. Have you looked at the CI failures? It seems some parsing tests have been broken.
   
   Also, you should fix the lint failures as well, if possible. See [doc here](https://arrow.apache.org/docs/developers/cpp/development.html?highlight=archery#code-style-linting-and-ci).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org