You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/16 02:13:02 UTC
[GitHub] [skywalking] wangwang89 opened a new pull request #7464: Modified document file
wangwang89 opened a new pull request #7464:
URL: https://github.com/apache/skywalking/pull/7464
Modify the customized indicators in the backend-receivers.md , and the VM indicators in the backend-vm-monitoring.md ,to make it easier for users to understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7464: Polish otel receiver doc
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7464:
URL: https://github.com/apache/skywalking/pull/7464#discussion_r689212776
##########
File path: docs/en/setup/backend/backend-vm-monitoring.md
##########
@@ -8,9 +8,11 @@ We define the VM entity as a `Service` in OAP, and use `vm::` as a prefix to ide
2. The OpenTelemetry Collector fetches metrics from node-exporter via Prometheus Receiver and pushes metrics to the SkyWalking OAP Server via the OpenCensus gRPC Exporter.
3. The SkyWalking OAP Server parses the expression with [MAL](../../concepts-and-designs/mal.md) to filter/calculate/aggregate and store the results.
-## Setup
-1. Set up [Prometheus node-exporter](https://prometheus.io/docs/guides/node-exporter/).
-2. Set up [OpenTelemetry Collector ](https://opentelemetry.io/docs/collector/). This is an example for OpenTelemetry Collector configuration [otel-collector-config.yaml](../../../../test/e2e/e2e-test/docker/promOtelVM/otel-collector-config.yaml).
+
+## Setup
Review comment:
This could be caused by IDE markdown format :) At least my local has similar change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on a change in pull request #7464: Polish otel receiver doc
Posted by GitBox <gi...@apache.org>.
wankai123 commented on a change in pull request #7464:
URL: https://github.com/apache/skywalking/pull/7464#discussion_r689211147
##########
File path: docs/en/setup/backend/backend-vm-monitoring.md
##########
@@ -8,9 +8,11 @@ We define the VM entity as a `Service` in OAP, and use `vm::` as a prefix to ide
2. The OpenTelemetry Collector fetches metrics from node-exporter via Prometheus Receiver and pushes metrics to the SkyWalking OAP Server via the OpenCensus gRPC Exporter.
3. The SkyWalking OAP Server parses the expression with [MAL](../../concepts-and-designs/mal.md) to filter/calculate/aggregate and store the results.
-## Setup
-1. Set up [Prometheus node-exporter](https://prometheus.io/docs/guides/node-exporter/).
-2. Set up [OpenTelemetry Collector ](https://opentelemetry.io/docs/collector/). This is an example for OpenTelemetry Collector configuration [otel-collector-config.yaml](../../../../test/e2e/e2e-test/docker/promOtelVM/otel-collector-config.yaml).
+
+## Setup
Review comment:
thanks, a small question, what's the changes here except the blank line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 merged pull request #7464: Polish otel receiver doc
Posted by GitBox <gi...@apache.org>.
wankai123 merged pull request #7464:
URL: https://github.com/apache/skywalking/pull/7464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org