[GitHub] [druid] somu-imply commented on a diff in pull request #14237: Updates to filter processing for inner query in Joins

["somu-imply (via GitHub)" <gi...@apache.org>]

somu-imply commented on code in PR #14237:
URL: https://github.com/apache/druid/pull/14237#discussion_r1190243551


##########
processing/src/main/java/org/apache/druid/segment/join/JoinableFactoryWrapper.java:
##########
@@ -178,15 +183,37 @@ static JoinClauseToFilterConversion convertJoinToFilter(
         }
 
         numValues -= columnValuesWithUniqueFlag.getColumnValues().size();
-        filters.add(Filters.toFilter(new InDimFilter(leftColumn, columnValuesWithUniqueFlag.getColumnValues())));
+        // For each column value which are received in order we increment the index
+        // and add it in the appropriate index in the map
+        int c = 0;
+        for (String val : columnValuesWithUniqueFlag.getColumnValues()) {

Review Comment:
   I see, I introduced the orderedSet to ensure the values lineup in order, but using duplicate values I could see the issue. Without using the linkedSet if I use unique non-sorted values in the input they also do not line up as for the TreeSet creating the wrong filters. I agree that we should limit the optimization as you suggested



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org