[GitHub] [incubator-superset] rusackas commented on a change in pull request #10094: style: listviews closer to SIP-34

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #10094:
URL: https://github.com/apache/incubator-superset/pull/10094#discussion_r442616368



##########
File path: superset-frontend/src/components/ListView/TableCollection.tsx
##########
@@ -29,6 +30,18 @@ interface Props {
   rows: TableInstance['rows'];
   loading: boolean;
 }
+
+const TableCell = styled.td`

Review comment:
       I see why you're adding `styled` here to apply props to the width, but there IS a possible performance implication here, if there wind up being a bajillion table cells, and Emotion starts bogging down. It may be more performant to use the prop to add a _class_ on the `td`, and then use emotion hire up in the DOM tree. I.e. 
   ```
   const Table = styled.table`
     td{
       &.xs { width: 25px; }
       &.sm { width: 50px; }
       &.md { width: 75px; }
       &.lg { width: 100px; }
       &.xl { width: 150px; }
       &.xxl { width: 200px; }
     }
   `
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org