You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-commits@db.apache.org by mb...@apache.org on 2023/01/01 17:21:58 UTC
[db-jdo] 06/07: JDO-823: "@Override" should be used on overriding and implementing methods
This is an automated email from the ASF dual-hosted git repository.
mbo pushed a commit to branch JDO-823
in repository https://gitbox.apache.org/repos/asf/db-jdo.git
commit 34abeed7736ec4374aedbce0a4e698b1f565eacc
Author: Michael Bouschen <Mi...@akquinet.de>
AuthorDate: Sun Jan 1 17:34:54 2023 +0100
JDO-823: "@Override" should be used on overriding and implementing methods
---
api/src/main/java/javax/jdo/ObjectState.java | 1 +
api/src/main/java/javax/jdo/identity/ByteIdentity.java | 4 ++++
api/src/main/java/javax/jdo/identity/CharIdentity.java | 4 ++++
api/src/main/java/javax/jdo/identity/IntIdentity.java | 4 ++++
api/src/main/java/javax/jdo/identity/LongIdentity.java | 4 ++++
api/src/main/java/javax/jdo/identity/ShortIdentity.java | 4 ++++
api/src/main/java/javax/jdo/identity/StringIdentity.java | 3 +++
7 files changed, 24 insertions(+)
diff --git a/api/src/main/java/javax/jdo/ObjectState.java b/api/src/main/java/javax/jdo/ObjectState.java
index 7b407e36..1956f36b 100644
--- a/api/src/main/java/javax/jdo/ObjectState.java
+++ b/api/src/main/java/javax/jdo/ObjectState.java
@@ -46,6 +46,7 @@ public enum ObjectState {
this.value = value;
}
+ @Override
public String toString() {
return value;
}
diff --git a/api/src/main/java/javax/jdo/identity/ByteIdentity.java b/api/src/main/java/javax/jdo/identity/ByteIdentity.java
index 42d04b2b..b3e4ca9b 100644
--- a/api/src/main/java/javax/jdo/identity/ByteIdentity.java
+++ b/api/src/main/java/javax/jdo/identity/ByteIdentity.java
@@ -106,6 +106,7 @@ public class ByteIdentity extends SingleFieldIdentity<ByteIdentity> {
* @param obj the other object
* @return true if both objects represent the same object id
*/
+ @Override
public boolean equals(Object obj) {
if (this == obj) {
return true;
@@ -138,6 +139,7 @@ public class ByteIdentity extends SingleFieldIdentity<ByteIdentity> {
* @return the key as an Object
* @since 2.0
*/
+ @Override
protected Object createKeyAsObject() {
return Byte.valueOf(key);
}
@@ -147,6 +149,7 @@ public class ByteIdentity extends SingleFieldIdentity<ByteIdentity> {
*
* @param out the output
*/
+ @Override
public void writeExternal(ObjectOutput out) throws IOException {
super.writeExternal(out);
out.writeByte(key);
@@ -157,6 +160,7 @@ public class ByteIdentity extends SingleFieldIdentity<ByteIdentity> {
*
* @param in the input
*/
+ @Override
public void readExternal(ObjectInput in) throws IOException, ClassNotFoundException {
super.readExternal(in);
key = in.readByte();
diff --git a/api/src/main/java/javax/jdo/identity/CharIdentity.java b/api/src/main/java/javax/jdo/identity/CharIdentity.java
index 59bd5eea..2f6456bb 100644
--- a/api/src/main/java/javax/jdo/identity/CharIdentity.java
+++ b/api/src/main/java/javax/jdo/identity/CharIdentity.java
@@ -107,6 +107,7 @@ public class CharIdentity extends SingleFieldIdentity<CharIdentity> {
* @param obj the other object
* @return true if both objects represent the same object id
*/
+ @Override
public boolean equals(Object obj) {
if (this == obj) {
return true;
@@ -139,6 +140,7 @@ public class CharIdentity extends SingleFieldIdentity<CharIdentity> {
* @return the key as an Object
* @since 2.0
*/
+ @Override
protected Object createKeyAsObject() {
return Character.valueOf(key);
}
@@ -148,6 +150,7 @@ public class CharIdentity extends SingleFieldIdentity<CharIdentity> {
*
* @param out the output
*/
+ @Override
public void writeExternal(ObjectOutput out) throws IOException {
super.writeExternal(out);
out.writeChar(key);
@@ -158,6 +161,7 @@ public class CharIdentity extends SingleFieldIdentity<CharIdentity> {
*
* @param in the input
*/
+ @Override
public void readExternal(ObjectInput in) throws IOException, ClassNotFoundException {
super.readExternal(in);
key = in.readChar();
diff --git a/api/src/main/java/javax/jdo/identity/IntIdentity.java b/api/src/main/java/javax/jdo/identity/IntIdentity.java
index 5f973cd2..f95d6e16 100644
--- a/api/src/main/java/javax/jdo/identity/IntIdentity.java
+++ b/api/src/main/java/javax/jdo/identity/IntIdentity.java
@@ -104,6 +104,7 @@ public class IntIdentity extends SingleFieldIdentity<IntIdentity> {
* @param obj the other object
* @return true if both objects represent the same object id
*/
+ @Override
public boolean equals(Object obj) {
if (this == obj) {
return true;
@@ -136,6 +137,7 @@ public class IntIdentity extends SingleFieldIdentity<IntIdentity> {
* @return the key as an Object
* @since 2.0
*/
+ @Override
protected Object createKeyAsObject() {
return Integer.valueOf(key);
}
@@ -145,6 +147,7 @@ public class IntIdentity extends SingleFieldIdentity<IntIdentity> {
*
* @param out the output
*/
+ @Override
public void writeExternal(ObjectOutput out) throws IOException {
super.writeExternal(out);
out.writeInt(key);
@@ -155,6 +158,7 @@ public class IntIdentity extends SingleFieldIdentity<IntIdentity> {
*
* @param in the input
*/
+ @Override
public void readExternal(ObjectInput in) throws IOException, ClassNotFoundException {
super.readExternal(in);
key = in.readInt();
diff --git a/api/src/main/java/javax/jdo/identity/LongIdentity.java b/api/src/main/java/javax/jdo/identity/LongIdentity.java
index 667a3fab..4ceff16c 100644
--- a/api/src/main/java/javax/jdo/identity/LongIdentity.java
+++ b/api/src/main/java/javax/jdo/identity/LongIdentity.java
@@ -105,6 +105,7 @@ public class LongIdentity extends SingleFieldIdentity<LongIdentity> {
* @param obj the other object
* @return true if both objects represent the same object id
*/
+ @Override
public boolean equals(Object obj) {
if (this == obj) {
return true;
@@ -150,6 +151,7 @@ public class LongIdentity extends SingleFieldIdentity<LongIdentity> {
* @return the key as an Object
* @since 2.0
*/
+ @Override
protected Object createKeyAsObject() {
return Long.valueOf(key);
}
@@ -159,6 +161,7 @@ public class LongIdentity extends SingleFieldIdentity<LongIdentity> {
*
* @param out the output
*/
+ @Override
public void writeExternal(ObjectOutput out) throws IOException {
super.writeExternal(out);
out.writeLong(key);
@@ -169,6 +172,7 @@ public class LongIdentity extends SingleFieldIdentity<LongIdentity> {
*
* @param in the input
*/
+ @Override
public void readExternal(ObjectInput in) throws IOException, ClassNotFoundException {
super.readExternal(in);
key = in.readLong();
diff --git a/api/src/main/java/javax/jdo/identity/ShortIdentity.java b/api/src/main/java/javax/jdo/identity/ShortIdentity.java
index 1c4cbf6c..c9d27acf 100644
--- a/api/src/main/java/javax/jdo/identity/ShortIdentity.java
+++ b/api/src/main/java/javax/jdo/identity/ShortIdentity.java
@@ -103,6 +103,7 @@ public class ShortIdentity extends SingleFieldIdentity<ShortIdentity> {
* @param obj the other object
* @return true if both objects represent the same object id
*/
+ @Override
public boolean equals(Object obj) {
if (this == obj) {
return true;
@@ -135,6 +136,7 @@ public class ShortIdentity extends SingleFieldIdentity<ShortIdentity> {
* @return the key as an Object
* @since 2.0
*/
+ @Override
protected Object createKeyAsObject() {
return Short.valueOf(key);
}
@@ -144,6 +146,7 @@ public class ShortIdentity extends SingleFieldIdentity<ShortIdentity> {
*
* @param out the output
*/
+ @Override
public void writeExternal(ObjectOutput out) throws IOException {
super.writeExternal(out);
out.writeShort(key);
@@ -154,6 +157,7 @@ public class ShortIdentity extends SingleFieldIdentity<ShortIdentity> {
*
* @param in the input
*/
+ @Override
public void readExternal(ObjectInput in) throws IOException, ClassNotFoundException {
super.readExternal(in);
key = in.readShort();
diff --git a/api/src/main/java/javax/jdo/identity/StringIdentity.java b/api/src/main/java/javax/jdo/identity/StringIdentity.java
index 5bf7dd98..ff3fe2b0 100644
--- a/api/src/main/java/javax/jdo/identity/StringIdentity.java
+++ b/api/src/main/java/javax/jdo/identity/StringIdentity.java
@@ -76,6 +76,7 @@ public class StringIdentity extends SingleFieldIdentity<StringIdentity> {
* @param obj the other object
* @return true if both objects represent the same object id
*/
+ @Override
public boolean equals(Object obj) {
if (this == obj) {
return true;
@@ -107,6 +108,7 @@ public class StringIdentity extends SingleFieldIdentity<StringIdentity> {
*
* @param out the output
*/
+ @Override
public void writeExternal(ObjectOutput out) throws IOException {
super.writeExternal(out);
out.writeObject(keyAsObject);
@@ -117,6 +119,7 @@ public class StringIdentity extends SingleFieldIdentity<StringIdentity> {
*
* @param in the input
*/
+ @Override
public void readExternal(ObjectInput in) throws IOException, ClassNotFoundException {
super.readExternal(in);
keyAsObject = in.readObject();