[calcite] branch master updated: [CALCITE-2927] The Javadoc and implement of RuleQueue.computeImportance() is inconsistent (Meng Wang)

[ho...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

hongze pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/calcite.git


The following commit(s) were added to refs/heads/master by this push:
     new 3124a85  [CALCITE-2927] The Javadoc and implement of RuleQueue.computeImportance() is inconsistent (Meng Wang)
3124a85 is described below

commit 3124a85b93ff2f1b79484c7bd4cc41835d4f1920
Author: wangzzu <wa...@163.com>
AuthorDate: Mon Mar 18 09:57:44 2019 +0800

    [CALCITE-2927] The Javadoc and implement of RuleQueue.computeImportance() is inconsistent (Meng Wang)
    
    Close apache/calcite#1111
---
 core/src/main/java/org/apache/calcite/plan/volcano/RuleQueue.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/core/src/main/java/org/apache/calcite/plan/volcano/RuleQueue.java b/core/src/main/java/org/apache/calcite/plan/volcano/RuleQueue.java
index ab025e3..25135f0 100644
--- a/core/src/main/java/org/apache/calcite/plan/volcano/RuleQueue.java
+++ b/core/src/main/java/org/apache/calcite/plan/volcano/RuleQueue.java
@@ -356,7 +356,7 @@ class RuleQueue {
    *
    * <ul>
    * <li>the root {@link RelSubset} has an importance of 1</li>
-   * <li>the importance of any other subset is the sum of its importance to
+   * <li>the importance of any other subset is the max of its importance to
    * its parents</li>
    * <li>The importance of children is pro-rated according to the cost of the
    * children. Consider a node which has a cost of 3, and children with costs
@@ -368,7 +368,7 @@ class RuleQueue {
    *
    * <p>The formula for the importance <i>I</i> of node n is:
    *
-   * <blockquote>I<sub>n</sub> = Sum<sub>parents p of n</sub>{I<sub>p</sub> .
+   * <blockquote>I<sub>n</sub> = Max<sub>parents p of n</sub>{I<sub>p</sub> .
    * W <sub>n, p</sub>}</blockquote>
    *
    * <p>where W<sub>n, p</sub>, the weight of n within its parent p, is