You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ma...@apache.org on 2024/03/21 22:08:26 UTC

(superset) 01/01: chore: rm references to .github/actions/cached-dependencies

This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch rm_cached_dependencies
in repository https://gitbox.apache.org/repos/asf/superset.git

commit dcc2683c7aab6cf7fa3f8457524ab51a4259ddcd
Author: Maxime Beauchemin <ma...@gmail.com>
AuthorDate: Thu Mar 21 15:08:11 2024 -0700

    chore: rm references to .github/actions/cached-dependencies
---
 .github/actions/cached-dependencies                   |  1 -
 .github/workflows/superset-applitool-cypress.yml      |  6 ------
 .github/workflows/superset-applitools-storybook.yml   |  2 --
 .github/workflows/superset-cli.yml                    |  1 -
 .github/workflows/superset-e2e.yml                    | 10 ----------
 .github/workflows/superset-frontend.yml               |  1 -
 .github/workflows/superset-python-integrationtest.yml |  3 ---
 .github/workflows/superset-python-presto-hive.yml     |  2 --
 .github/workflows/superset-translations.yml           |  2 --
 .gitmodules                                           |  3 ---
 10 files changed, 31 deletions(-)

diff --git a/.github/actions/cached-dependencies b/.github/actions/cached-dependencies
deleted file mode 160000
index 064315d61e..0000000000
--- a/.github/actions/cached-dependencies
+++ /dev/null
@@ -1 +0,0 @@
-Subproject commit 064315d61e424e60d440fa77e8afda19cdd7211a
diff --git a/.github/workflows/superset-applitool-cypress.yml b/.github/workflows/superset-applitool-cypress.yml
index fa5da3ee9c..4659f2d71d 100644
--- a/.github/workflows/superset-applitool-cypress.yml
+++ b/.github/workflows/superset-applitool-cypress.yml
@@ -60,7 +60,6 @@ jobs:
       - name: Setup Python
         uses: ./.github/actions/setup-backend/
       - name: Import test data
-        uses: ./.github/actions/cached-dependencies
         with:
           run: testdata
       - name: Setup Node.js
@@ -68,24 +67,19 @@ jobs:
         with:
           node-version: ${{ matrix.node }}
       - name: Install npm dependencies
-        uses: ./.github/actions/cached-dependencies
         with:
           run: npm-install
       - name: Build javascript packages
-        uses: ./.github/actions/cached-dependencies
         with:
           run: build-instrumented-assets
       - name: Setup Postgres
         if: steps.check.outcome == 'failure'
-        uses: ./.github/actions/cached-dependencies
         with:
           run: setup-postgres
       - name: Install cypress
-        uses: ./.github/actions/cached-dependencies
         with:
           run: cypress-install
       - name: Run Cypress
-        uses: ./.github/actions/cached-dependencies
         env:
           CYPRESS_BROWSER: ${{ matrix.browser }}
         with:
diff --git a/.github/workflows/superset-applitools-storybook.yml b/.github/workflows/superset-applitools-storybook.yml
index f0565bb1b0..e24544f361 100644
--- a/.github/workflows/superset-applitools-storybook.yml
+++ b/.github/workflows/superset-applitools-storybook.yml
@@ -43,11 +43,9 @@ jobs:
         with:
           node-version: ${{ matrix.node }}
       - name: Install eyes-storybook dependencies
-        uses: ./.github/actions/cached-dependencies
         with:
           run: eyes-storybook-dependencies
       - name: Install NPM dependencies
-        uses: ./.github/actions/cached-dependencies
         with:
           run: npm-install
       - name: Run Applitools Eyes-Storybook
diff --git a/.github/workflows/superset-cli.yml b/.github/workflows/superset-cli.yml
index 07aa01ebfa..d2f9e7f126 100644
--- a/.github/workflows/superset-cli.yml
+++ b/.github/workflows/superset-cli.yml
@@ -56,7 +56,6 @@ jobs:
         if: steps.check.outcome == 'failure'
       - name: Setup Postgres
         if: steps.check.outcome == 'failure'
-        uses: ./.github/actions/cached-dependencies
         with:
           run: setup-postgres
       - name: superset init
diff --git a/.github/workflows/superset-e2e.yml b/.github/workflows/superset-e2e.yml
index 4c2423238b..e72a5acf6f 100644
--- a/.github/workflows/superset-e2e.yml
+++ b/.github/workflows/superset-e2e.yml
@@ -67,12 +67,8 @@ jobs:
           PR_NUMBER: ${{ github.event.pull_request.number }}
         continue-on-error: true
         run: ./scripts/ci_check_no_file_changes.sh python frontend
-      - name: Setup Python
-        if: steps.check.outcome == 'failure'
-        uses: ./.github/actions/setup-backend/
       - name: OS dependencies
         if: steps.check.outcome == 'failure'
-        uses: ./.github/actions/cached-dependencies
         with:
           run: apt-get-install
       - name: Setup Python
@@ -80,12 +76,10 @@ jobs:
         if: steps.check.outcome == 'failure'
       - name: Setup postgres
         if: steps.check.outcome == 'failure'
-        uses: ./.github/actions/cached-dependencies
         with:
           run: setup-postgres
       - name: Import test data
         if: steps.check.outcome == 'failure'
-        uses: ./.github/actions/cached-dependencies
         with:
           run: testdata
       - name: Setup Node.js
@@ -94,22 +88,18 @@ jobs:
           node-version: "16"
       - name: Install npm dependencies
         if: steps.check.outcome == 'failure'
-        uses: ./.github/actions/cached-dependencies
         with:
           run: npm-install
       - name: Build javascript packages
         if: steps.check.outcome == 'failure'
-        uses: ./.github/actions/cached-dependencies
         with:
           run: build-instrumented-assets
       - name: Install cypress
         if: steps.check.outcome == 'failure'
-        uses: ./.github/actions/cached-dependencies
         with:
           run: cypress-install
       - name: Run Cypress
         if: steps.check.outcome == 'failure'
-        uses: ./.github/actions/cached-dependencies
         env:
           CYPRESS_BROWSER: ${{ matrix.browser }}
           CYPRESS_KEY: YjljODE2MzAtODcwOC00NTA3LWE4NmMtMTU3YmFmMjIzOTRhCg==
diff --git a/.github/workflows/superset-frontend.yml b/.github/workflows/superset-frontend.yml
index bce75a06bf..9d4595d870 100644
--- a/.github/workflows/superset-frontend.yml
+++ b/.github/workflows/superset-frontend.yml
@@ -42,7 +42,6 @@ jobs:
           node-version: "16"
       - name: Install dependencies
         if: steps.check.outcome == 'failure'
-        uses: ./.github/actions/cached-dependencies
         with:
           run: npm-install
       - name: eslint
diff --git a/.github/workflows/superset-python-integrationtest.yml b/.github/workflows/superset-python-integrationtest.yml
index 28df703a92..b895f9483d 100644
--- a/.github/workflows/superset-python-integrationtest.yml
+++ b/.github/workflows/superset-python-integrationtest.yml
@@ -57,7 +57,6 @@ jobs:
           python-version: ${{ matrix.python-version }}
       - name: Setup MySQL
         if: steps.check.outcome == 'failure'
-        uses: ./.github/actions/cached-dependencies
         with:
           run: |
             setup-mysql
@@ -116,7 +115,6 @@ jobs:
           python-version: ${{ matrix.python-version }}
       - name: Setup Postgres
         if: steps.check.outcome == 'failure'
-        uses: ./.github/actions/cached-dependencies
         with:
           run: |
             setup-postgres
@@ -170,7 +168,6 @@ jobs:
           python-version: ${{ matrix.python-version }}
       - name: Install dependencies
         if: steps.check.outcome == 'failure'
-        uses: ./.github/actions/cached-dependencies
         with:
           run: |
             # sqlite needs this working directory
diff --git a/.github/workflows/superset-python-presto-hive.yml b/.github/workflows/superset-python-presto-hive.yml
index dd8a839d62..5b368cca70 100644
--- a/.github/workflows/superset-python-presto-hive.yml
+++ b/.github/workflows/superset-python-presto-hive.yml
@@ -71,7 +71,6 @@ jobs:
         if: steps.check.outcome == 'failure'
       - name: Setup Postgres
         if: steps.check.outcome == 'failure'
-        uses: ./.github/actions/cached-dependencies
         with:
           run: setup-postgres
       - name: Run celery
@@ -139,7 +138,6 @@ jobs:
         if: steps.check.outcome == 'failure'
       - name: Setup Postgres
         if: steps.check.outcome == 'failure'
-        uses: ./.github/actions/cached-dependencies
         with:
           run: setup-postgres
       - name: Run celery
diff --git a/.github/workflows/superset-translations.yml b/.github/workflows/superset-translations.yml
index fb00f9f2ea..4215c1f816 100644
--- a/.github/workflows/superset-translations.yml
+++ b/.github/workflows/superset-translations.yml
@@ -27,7 +27,6 @@ jobs:
         with:
           node-version: "16"
       - name: Install dependencies
-        uses: ./.github/actions/cached-dependencies
         with:
           run: npm-install
       - name: lint
@@ -51,7 +50,6 @@ jobs:
         with:
           python-version: ${{ matrix.python-version }}
       - name: Install dependencies
-        uses: ./.github/actions/cached-dependencies
         with:
           run: |
             apt-get-install
diff --git a/.gitmodules b/.gitmodules
index bf3f8a1b37..79af2e17c3 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -24,9 +24,6 @@
 [submodule ".github/actions/file-changes-action"]
 	path = .github/actions/file-changes-action
 	url = https://github.com/trilom/file-changes-action
-[submodule ".github/actions/cached-dependencies"]
-	path = .github/actions/cached-dependencies
-	url = https://github.com/apache-superset/cached-dependencies
 [submodule ".github/actions/comment-on-pr"]
 	path = .github/actions/comment-on-pr
 	url = https://github.com/unsplash/comment-on-pr