[PR] Fix Firebird BLOB segment test compilation [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu opened a new pull request, #40156:
URL: https://github.com/apache/shardingsphere/pull/40156

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix Firebird BLOB segment test compilation [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu commented on PR #40156:
URL: https://github.com/apache/shardingsphere/pull/40156#issuecomment-6106812953

   ### Result
   
   **Review Result: Mergeable**
   
   Fixed the test call to match the existing method signature while preserving the last-segment behavior and assertions.
   
   ### Evidence
   
   - Added `false` to explicitly use a segmented BLOB. The read path does not depend on this flag, so all three last-segment scenarios retain their meaning.
   - Current-source compilation passed: 50 Firebird frontend production files and 43 test files. All 12 focused tests passed; Maven exited with code 0.
   - Exact-file `spotless:check checkstyle:check` passed with exit code 0. Both checks covered the single changed file, with no Checkstyle errors. `git diff --check` also passed.
   - Independent defensive-code review found no added, expanded, or strengthened defensive logic.
   
   ### Coverage
   
   - Standalone local candidate against baseline `8cce4ae7cccc6c46054a15ca98b208c36149336b`. Reviewed 1/1 file: `proxy/frontend/dialect/firebird/src/test/java/org/apache/shardingsphere/proxy/frontend/firebird/command/query/blob/FirebirdGetBlobSegmentCommandExecutorTest.java:146`. The only change adds one argument.
   - Reviewed the BLOB test fixture for the minimal compilation fix. Production code, interfaces, assertions, and existing untracked files remain unchanged. No new project commitment or credible performance risk was introduced.
   - Completed root-cause, contract-impact, tests/runtime, and final convergence reviews. No unresolved issues or evidence gaps remain.
   - This conclusion covers local code correctness. Local tests and style checks passed; remote CI was not reviewed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix Firebird BLOB segment test compilation [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu merged PR #40156:
URL: https://github.com/apache/shardingsphere/pull/40156


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org