You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2021/12/12 05:40:07 UTC

[GitHub] [thrift] fishy commented on a change in pull request #2487: THRIFT-5488: Define PY_SSIZE_T_CLEAN to fix error with using PyObject_CallFunction in python 3.10

fishy commented on a change in pull request #2487:
URL: https://github.com/apache/thrift/pull/2487#discussion_r767225934



##########
File path: lib/py/test/test_thrift_file/TestServer.thrift
##########
@@ -16,8 +16,12 @@
 # specific language governing permissions and limitations
 # under the License.
 #
- 
+
+struct Message {
+   1: optional string body,
+   2: optional i64 num,
+}
 
 service TestServer{
-	string add_and_get_msg(1:string msg)
+	Message add_and_get_msg(1:Message msg)

Review comment:
       I don't think this change is explained in either the PR description of the ticket?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org