[GitHub] jihoonson commented on a change in pull request #7041: Kill all running tasks when the supervisor task is killed

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #7041: Kill all running tasks when the supervisor task is killed
URL: https://github.com/apache/incubator-druid/pull/7041#discussion_r259547797
 
 

 ##########
 File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/SinglePhaseParallelIndexTaskRunner.java
 ##########
 @@ -111,6 +111,11 @@
   @Override
   public TaskState run() throws Exception
   {
+    if (baseFirehoseFactory.getNumSplits() == 0) {
 
 Review comment:
   If it's 1, the native parallel task currently does the same thing: the supervisor task will run a sub task for the single split. Do you think it's better to process in the supervisor task rather than processing in the sub task?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org