You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/04/02 13:21:19 UTC
[GitHub] [dolphinscheduler] 1qase4 opened a new pull request #9336: Update DataSourceServiceImpl.java
1qase4 opened a new pull request #9336:
URL: https://github.com/apache/dolphinscheduler/pull/9336
This pull request fix Execption message miss, modify file dolphinscheduler-api\src\main\java\org\apache\dolphinscheduler\api\service\impl\DataSourceServiceImpl.java
Because of org.apache.dolphinscheduler.plugin.datasource.api.client.CommonDataSourceClient#checkClient method convert sqlException to RuntimeException, org.apache.dolphinscheduler.api.service.impl.DataSourceServiceImpl#checkConnection method can't get right exception message.
![image](https://user-images.githubusercontent.com/19678580/161385207-f7df734f-451d-40c7-b856-e6220227c8b7.png)
This pull request is code cleanup without any test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on pull request #9336: Update DataSourceServiceImpl.java
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on pull request #9336:
URL: https://github.com/apache/dolphinscheduler/pull/9336#issuecomment-1086645817
Hi @1qase4, please create an issue link to this pr. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org