You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/29 17:14:20 UTC

[GitHub] [airflow] nathadfield opened a new pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

nathadfield opened a new pull request #17321:
URL: https://github.com/apache/airflow/pull/17321


   Closes: #17032 
   
   *Recreated from #17252 
   
   `BigQueryInsertJobOperator` requires the specification of a configuration dict but, at present, this results in poor SQL rendering; especially if the queries are big or complex.
   
   ### Current Example
   
   <img width="1670" alt="127119136-3d6f1f57-c941-4b06-b3f3-c6094b31f821" src="https://user-images.githubusercontent.com/967119/127535467-adf52f70-362b-4a97-b7ae-8755d2da2988.png">
   
   This PR attempts to implement the capability for specific elements of a dictionary provided to an operator to be rendered individually with the appropriate renderer.
   
   For example, when the following configuration is submitted to `BigQueryInsertJobOperator` then, in addition to the JSON rendering of `configuration` the provided SQL should be separately rendered.
   
   ```
   sql = '''
   INSERT INTO `target_project.target_dataset.target_table`
   (col1, col2, col3, col4)
   SELECT col1, col2, col3, col4
   FROM `source_project.source_dataset.source_table`
   '''
   
   test = BigQueryInsertJobOperator(
       task_id='test',
       gcp_conn_id='my_gcp_connection',
       configuration={"query": {"query": sql,
                                "destinationTable": {"projectId": 'my_project',
                                                     "datasetId": 'my_dataset',
                                                     "tableId": 'my_table'},
                                "writeDisposition": 'WRITE_TRUNCATE',
                                "useLegacySql": False}
                      }
   )
   ```
   
   To achieve it, this PR enables any operator to receive a dot-separated path from `template_field_renderers` along with the renderer type.  In this case we want `BigQueryInsertJobOperator` to extract the value from `configuration` dict where the key path is `query.query`.  This is fully represented as follows:
   
    `template_fields_renderers = {"configuration": "json", "configuration.query.query": "sql"}`
   
   When building the rendered page, we check if the content is a dict - e.g. `configuration` - then, if so, return a generator object that yields every possible path of keys (`get_key_paths`) in the form `key1.key2.key3...keyX`. 
   
   Using this we can then check to see if any of these paths match with what we have in `template_field_renderers` and, if so, what the renderer is.  If it is a valid renderer then we can use that path to retrieve the value from the configuration (`get_value_from_path`).
   
   ```
   if isinstance(content, dict):
       for dict_keys in get_key_paths(content):
           template_path = '.'.join((template_field, dict_keys))
           renderer = task.template_fields_renderers.get(template_path, template_path)
           if renderer in renderers:
               content_value = get_value_from_path(dict_keys, content)
               html_dict[template_path] = renderers[renderer](content_value)
   ```
   
   The result of this is a rendered page which looks like the following:
   
   <img width="1670" alt="Screenshot 2021-07-26 at 14 51 48" src="https://user-images.githubusercontent.com/967119/127123123-93beb8dd-eac3-44db-adb8-1e5a1115259a.png">
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk edited a comment on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-890978312


   Some errors with doc building though :). 
   
   `./breeze build-docs -- --package-filter apache-airflow`  
   
   Should allow you to build it quickly locally 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-890927721


   One more small request - Could you please alse explain this new feature in https://airflow.apache.org/docs/apache-airflow/stable/howto/custom-operator.html?highlight=custom#templating - there template_rendering is mentioned, but it would be nice to add an explanation and example there as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk edited a comment on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-890927721


   One more small request @nathadfield - Could you please also explain this new feature in https://airflow.apache.org/docs/apache-airflow/stable/howto/custom-operator.html?highlight=custom#templating - there template_rendering is mentioned, but it would be nice to add an explanation and example there as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-903548833


   > @potiuk I'm more than happy to I'm not sure what you had in mind exactly or where to put it. At the moment, the only operator that has a path which can be rendered is BigQueryInsertJobOperator.
   
   That's enough :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-891143224


   Good job on that :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] nathadfield commented on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
nathadfield commented on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-890957036


   @potiuk Done!  Happy with the explanation?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-890115026


   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk edited a comment on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-890927721


   One more small request @nathadfield - Could you please alse explain this new feature in https://airflow.apache.org/docs/apache-airflow/stable/howto/custom-operator.html?highlight=custom#templating - there template_rendering is mentioned, but it would be nice to add an explanation and example there as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk merged pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17321:
URL: https://github.com/apache/airflow/pull/17321


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-890978312


   Some errors with doc building though :). 
   
   `./breeze build-docs -- --package filter apache-airlfow`  
   
   Should allow you to build it quickly locally 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] nathadfield commented on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
nathadfield commented on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-903542861


   @potiuk I'm more than happy to I'm not sure what you had in mind exactly or where to put it.  At the moment, the only operator that has a path which can be rendered is BigQueryInsertJobOperator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-891085522


   No worries. we can merge it anyway :)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] nathadfield commented on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
nathadfield commented on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-891086402


   Awesome!  Thanks very much and for your help!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk edited a comment on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-890927721


   One more small request @nathadfield - Could you please also explain this new feature in https://airflow.apache.org/docs/apache-airflow/stable/howto/custom-operator.html?highlight=custom#templating - there template_rendering is mentioned, but it would be nice to add an explanation and example as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-890931618


   at the same time - the list of lexers got longer, so would be nice to refresh it :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-902190048


   > @potiuk Might we expect the core Airflow aspect of this to appear in 2.2? I guess there would also need to be a Google provider version release afterwards too.
   
   Yeah. We have not yet cut 2.2 branch, so everything merged in main is "in".
   
   BTW. That made me realise  that we should make sure that that if we specify the new "nested" renderers in the in a provider, theold airflow will still work with them (and not break the UI or anything). Maybe what you should do really - is to add those new field renderers now - so that we can release ithem  without airflow yet supporting them (and we make sure that they work without problems in current airflow) ? 
   
   Could you please add such a change to e provider and check it maybe ? (just reverting your change in main should show how old airlfow will behave in this case.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] nathadfield commented on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
nathadfield commented on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-902509415


   @potiuk There doesn't appear to be any UI issues if you specify a key path in a provider but the version of core Airflow doesn't have this capability yet.
   
   The existing code in [views.py](https://github.com/apache/airflow/blob/2.1.2/airflow/www/views.py#L970) looks up values from `template_field_renderers` against the operator class but these key paths will never match with anything.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] nathadfield commented on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
nathadfield commented on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-889729487


   The failing Sqlite Py3.6 test seems to be unrelated to the changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-890115179


   Can you please rebase @nathadfield ? We have fixed some failures in main , and it would be great to re-run that one through all tests?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mehmax commented on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
mehmax commented on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-890058655


   Hi @nathadfield, checking and rendering op_kwargs individually would totally solve the Issue I faced.
   Looks good to me now!
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk edited a comment on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-890978312


   Some errors with doc building though :). 
   
   `./breeze build-docs -- --package filter apache-airflow`  
   
   Should allow you to build it quickly locally 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] nathadfield commented on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
nathadfield commented on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-890857307


   @potiuk Rebased and all tests have ran successfully!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] nathadfield commented on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
nathadfield commented on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-891011912


   Ah!  My bad.  Should be ready once everything runs through again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-902902372


   Great ! thanks @nathadfield - would you make some pr to add some example operators with useful paths so that we can release it in the new batch of providers (I plan to cut them shortly - maybe early next week), and then they will be ready when we release 2.2 :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-890926485


   Yeah. Seems that thanks to some fixes by @ephraimbuddy we are gone a bit closer to the "green one" on the PRS.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] nathadfield commented on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
nathadfield commented on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-901818140


   @potiuk Might we expect the core Airflow aspect of this to appear in 2.2?  I guess there would also need to be a Google provider version release afterwards too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] nathadfield commented on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
nathadfield commented on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-902493032


   @potiuk Good point!  Let me take a look at that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] nathadfield commented on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
nathadfield commented on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-890928833


   @potiuk Ah, yeah!  I sure can!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] nathadfield commented on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
nathadfield commented on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-891079952


   @potiuk Well, that's annoying.  Unrelated test failures again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] nathadfield edited a comment on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

Posted by GitBox <gi...@apache.org>.
nathadfield edited a comment on pull request #17321:
URL: https://github.com/apache/airflow/pull/17321#issuecomment-902509415


   @potiuk There doesn't appear to be any UI issues if you specify a key path in a provider but the version of core Airflow doesn't have the rendering capability yet.
   
   The existing code in [views.py](https://github.com/apache/airflow/blob/2.1.2/airflow/www/views.py#L970) looks up values from `template_field_renderers` against the operator class but these key paths will never match with anything.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org