You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by mbalassi <gi...@git.apache.org> on 2015/06/06 13:55:27 UTC

[GitHub] flink pull request: [FLINK-2153] Exclude Hbase annotations

GitHub user mbalassi opened a pull request:

    https://github.com/apache/flink/pull/800

    [FLINK-2153] Exclude Hbase annotations

    This is a temporal workaround for a bug in hbase.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mbalassi/flink flink-2153

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/800.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #800
    
----
commit 5f7ac25aa63354b3995dd6dc016ca9901dd2a8e4
Author: mbalassi <mb...@apache.org>
Date:   2015-06-06T11:36:08Z

    [FLINK-2153] Exclude Hbase annotations
    
    This is a temporal workaround for a bug in hbase.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2153] Exclude Hbase annotations

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/800


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2153] Exclude Hbase annotations

Posted by mbalassi <gi...@git.apache.org>.

Github user mbalassi commented on the pull request:

    https://github.com/apache/flink/pull/800#issuecomment-109893732
  
    I prefer 2 warnings to a sometimes error. :) Merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2153] Exclude Hbase annotations

Posted by rmetzger <gi...@git.apache.org>.

Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/800#issuecomment-109807683
  
    This change will cause some java compiler warnings, because our class `org.apache.flink.addons.hbase.TableInputFormat` has a field `org.apache.hadoop.hbase.client.HTable` which has two annotations:
    ```java
    @InterfaceAudience.Public
    @InterfaceStability.Stable
    public class HTable implements HTableInterface {
    ```
    And these annotations are in the "hbase-annotations" package. So the compiler will not be able to find the annotations and complain about it (without failing).
    
    Still, I think we can merge the change ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---