You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "justinpark (via GitHub)" <gi...@apache.org> on 2024/01/31 18:19:45 UTC
[PR] fix(sqllab): autosync fail on migrated queryEditor [superset]
justinpark opened a new pull request, #26922:
URL: https://github.com/apache/superset/pull/26922
### SUMMARY
Once `migrateQueryEditorFromLocalStorage` executes successfully, the queryEditor continues to retain `inLocalStorage` as `true`. Consequently, it is filtered out from the backend persist syncer. Furthermore, this action can be initiated multiple times, potentially storing the same query editor in the backend more than once, as the Single Page Application (SPA) navigation can trigger the componentDidMount.
This commit corrects the missing inLocalStorage update required for the hotfix.
### TESTING INSTRUCTIONS
test specs
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sqllab): autosync fail on migrated queryEditor [superset]
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark merged PR #26922:
URL: https://github.com/apache/superset/pull/26922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org