You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/05/18 08:19:05 UTC

[GitHub] [skywalking] myfairys opened a new issue #6963: when i use custom config and field type is float, i can't get right value.

myfairys opened a new issue #6963:
URL: https://github.com/apache/skywalking/issues/6963


    Bug
   ___
   ### Question
   when i use custom config and field type is float, i can't get right value. 
   ___
   ### Bug
   I use skywalking 8.1.0，but the same code util 8.5.0，and use jdk8、windows 10.
   
   It's occur to Agent.
   I look up source code,i get it. to Class `ConfigInitializer`
   `} else if (boolean.class.equals(type) || Boolean.class.equals(type)) {
               result = Boolean.valueOf(value);
           } else if (float.class.equals(type) || Float.class.equals(type)) {
               result = Boolean.valueOf(value);`
   
   So is it a bug?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] zifeihan commented on issue #6963: when i use custom config and field type is float, i can't get right value.

Posted by GitBox <gi...@apache.org>.
zifeihan commented on issue #6963:
URL: https://github.com/apache/skywalking/issues/6963#issuecomment-843903963


   @wu-sheng 
   i will try to fix it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #6963: when i use custom config and field type is float, i can't get right value.

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6963:
URL: https://github.com/apache/skywalking/issues/6963#issuecomment-842972842


   Yes, this is a bug.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] myfairys commented on issue #6963: when i use custom config and field type is float, i can't get right value.

Posted by GitBox <gi...@apache.org>.
myfairys commented on issue #6963:
URL: https://github.com/apache/skywalking/issues/6963#issuecomment-843888266


   ok


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #6963: when i use custom config and field type is float, i can't get right value.

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6963:
URL: https://github.com/apache/skywalking/issues/6963#issuecomment-843875027


   @myfairys Are you going to send a pull request to fix this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] myfairys commented on issue #6963: when i use custom config and field type is float, i can't get right value.

Posted by GitBox <gi...@apache.org>.
myfairys commented on issue #6963:
URL: https://github.com/apache/skywalking/issues/6963#issuecomment-843883145


   > @myfairys Are you going to send a pull request to fix this?
   
   @wu-sheng I'm sorry,i'm not 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] myfairys commented on issue #6963: when i use custom config and field type is float, i can't get right value.

Posted by GitBox <gi...@apache.org>.
myfairys commented on issue #6963:
URL: https://github.com/apache/skywalking/issues/6963#issuecomment-843883405


   > @myfairys Are you going to send a pull request to fix this?
   
   @wu-sheng I'm sorry,i'm not 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #6963: when i use custom config and field type is float, i can't get right value.

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #6963:
URL: https://github.com/apache/skywalking/issues/6963


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #6963: when i use custom config and field type is float, i can't get right value.

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6963:
URL: https://github.com/apache/skywalking/issues/6963#issuecomment-843884797


   Thanks for updating. Remove the milestone, this is a low priority issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org