You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/26 04:34:03 UTC
[GitHub] [pulsar] michaeljmarshall opened a new pull request, #16225: [broker] ServerCnx: log at warning level when topic not found
michaeljmarshall opened a new pull request, #16225:
URL: https://github.com/apache/pulsar/pull/16225
### Motivation
In https://github.com/apache/pulsar/pull/13950, we switched an error log to an info log. @hsaputra requested on Pulsar Slack we use warn level so that alerts still fire in for the case when the topic is not found.
### Modifications
* Replace `info` with `warn` when topic is not found in the `ServerCnx` class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #16225: [broker] ServerCnx: log at warning level when topic not found
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #16225:
URL: https://github.com/apache/pulsar/pull/16225#issuecomment-1275230382
# [Codecov](https://codecov.io/gh/apache/pulsar/pull/16225?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@ce24db1`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #16225 +/- ##
=========================================
Coverage ? 29.96%
Complexity ? 3959
=========================================
Files ? 393
Lines ? 43419
Branches ? 4462
=========================================
Hits ? 13012
Misses ? 28456
Partials ? 1951
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `29.96% <0.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall closed pull request #16225: [broker] ServerCnx: log at warning level when topic not found
Posted by GitBox <gi...@apache.org>.
michaeljmarshall closed pull request #16225: [broker] ServerCnx: log at warning level when topic not found
URL: https://github.com/apache/pulsar/pull/16225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall merged pull request #16225: [improve][broker] ServerCnx: log at warning level when topic not found
Posted by GitBox <gi...@apache.org>.
michaeljmarshall merged PR #16225:
URL: https://github.com/apache/pulsar/pull/16225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dave2wave commented on pull request #16225: [broker] ServerCnx: log at warning level when topic not found
Posted by GitBox <gi...@apache.org>.
dave2wave commented on PR #16225:
URL: https://github.com/apache/pulsar/pull/16225#issuecomment-1177996236
When I'm looking at broker logs I am scanning for `WARN` and `ERROR`. While this is an user error it is still something the operator may need to help their user identify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dave2wave commented on pull request #16225: [broker] ServerCnx: log at warning level when topic not found
Posted by GitBox <gi...@apache.org>.
dave2wave commented on PR #16225:
URL: https://github.com/apache/pulsar/pull/16225#issuecomment-1177999916
@merlimat on the clusters that you operate are you paged on `WARN`? If not then I don't see this change as noise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hsaputra commented on pull request #16225: [broker] ServerCnx: log at warning level when topic not found
Posted by GitBox <gi...@apache.org>.
hsaputra commented on PR #16225:
URL: https://github.com/apache/pulsar/pull/16225#issuecomment-1167615267
@merlimat - this indicates something is wrong and need to be fixed in either client or server.
It is "noise" that needs attention based on out experience running in production bc indeed something not matching.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on pull request #16225: [broker] ServerCnx: log at warning level when topic not found
Posted by GitBox <gi...@apache.org>.
Jason918 commented on PR #16225:
URL: https://github.com/apache/pulsar/pull/16225#issuecomment-1229151273
@merlimat PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hsaputra commented on pull request #16225: [broker] ServerCnx: log at warning level when topic not found
Posted by GitBox <gi...@apache.org>.
hsaputra commented on PR #16225:
URL: https://github.com/apache/pulsar/pull/16225#issuecomment-1166419119
LGTM +1(non binding)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #16225: [broker] ServerCnx: log at warning level when topic not found
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #16225:
URL: https://github.com/apache/pulsar/pull/16225#issuecomment-1275196153
Triggering a new CI build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #16225: [broker] ServerCnx: log at warning level when topic not found
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16225:
URL: https://github.com/apache/pulsar/pull/16225#issuecomment-1226691796
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org