You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2018/08/22 18:40:37 UTC

[GitHub] HanumathRao commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0

HanumathRao commented on a change in pull request #1425: DRILL-6647: Update Calcite version to 1.17.0
URL: https://github.com/apache/drill/pull/1425#discussion_r212064539
 
 

 ##########
 File path: exec/java-exec/src/main/codegen/data/Parser.tdd
 ##########
 @@ -85,13 +85,17 @@
 
   # List of methods for parsing extensions to "DROP" calls.
   # Each must accept arguments "(SqlParserPos pos)".
-    dropStatementParserMethods: [
+  dropStatementParserMethods: [
   ]
 
   # List of keywords from "keywords" section that are not reserved.
-    nonReservedKeywords: [
+  nonReservedKeywords: [
   ]
 
+  # List of additional join types. Each is a method with no arguments.
 
 Review comment:
   I am not clear as to why are these changes required for the upgrade?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services