You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "timeabarna (via GitHub)" <gi...@apache.org> on 2023/04/20 11:42:15 UTC
[GitHub] [nifi] timeabarna opened a new pull request, #7185: NIFI-11473 Flow version change in NiFi should not stop a component wh…
timeabarna opened a new pull request, #7185:
URL: https://github.com/apache/nifi/pull/7185
…en only position is changed
# Summary
When going from one flow version to another and the position of a component is changing, but not its configuration, the component should not be stopped.
[NIFI-11473](https://issues.apache.org/jira/browse/NIFI-11473)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #7185: NIFI-11473 Flow version change in NiFi should not stop a component wh…
Posted by "mattyb149 (via GitHub)" <gi...@apache.org>.
mattyb149 commented on PR #7185:
URL: https://github.com/apache/nifi/pull/7185#issuecomment-1526032749
+1 LGTM, reproduced without the PR and verified the behavior with the PR is as expected. Thanks for the fix! Merging to main and 1.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] timeabarna commented on pull request #7185: NIFI-11473 Flow version change in NiFi should not stop a component wh…
Posted by "timeabarna (via GitHub)" <gi...@apache.org>.
timeabarna commented on PR #7185:
URL: https://github.com/apache/nifi/pull/7185#issuecomment-1521344218
Hello @mattyb149,
I've created a GenerateFlowFile processor which is running. Created a version where only position changed.
Added debug point at FlowUpdateResource updateFlow method and a debug point to StandardVersionedFlowSynchronizer updateProcessor method.
At version change, without patch:
FlowUpdateResource updateFlow runningComponents set contains GenerateFlowFile processor.
StandardVersionedFlowSynchronizer updateProcessor goes to the updateProcessor if branch
nifi-app.log shows FlowUpdateResource Stopping 1 Processors and FlowUpdateResource Restarting 1 Processors
With patch:
FlowUpdateResource updateFlow runningComponents set empty.
StandardVersionedFlowSynchronizer updateProcessor goes to the setPosition if branch
nifi-app.log shows FlowUpdateResource Stopping 0 Processors and FlowUpdateResource Restarting 0 Processors
If my memory serves well only Updating Flow can be seen on UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 closed pull request #7185: NIFI-11473 Flow version change in NiFi should not stop a component wh…
Posted by "mattyb149 (via GitHub)" <gi...@apache.org>.
mattyb149 closed pull request #7185: NIFI-11473 Flow version change in NiFi should not stop a component wh…
URL: https://github.com/apache/nifi/pull/7185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #7185: NIFI-11473 Flow version change in NiFi should not stop a component wh…
Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 commented on PR #7185:
URL: https://github.com/apache/nifi/pull/7185#issuecomment-1521411080
What I usually do to check this:
- have a GenerateFlowFile to InvokeHTTP
- have a ListenHTTP
Version this is as v1.
Move the ListenHTTP processor. Version this is as v2.
With processors running, without the fix, v1 to v2 would generate errors because ListenHTTP is restarted and InvokeHTTP cannot send data during the restart. With the fix, there should be no error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #7185: NIFI-11473 Flow version change in NiFi should not stop a component wh…
Posted by "mattyb149 (via GitHub)" <gi...@apache.org>.
mattyb149 commented on PR #7185:
URL: https://github.com/apache/nifi/pull/7185#issuecomment-1520226208
Is there a reproduction path for this? Using the registry I started the processor then saved the version. Then I moved the processor and committed the changes. When I change version back, it appears to set the desired version but the processor is not stopped (although a dialog pops up saying . This is without the fix in this PR, so I'm thinking there's a different way to reproduce this behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #7185: NIFI-11473 Flow version change in NiFi should not stop a component wh…
Posted by "mattyb149 (via GitHub)" <gi...@apache.org>.
mattyb149 commented on PR #7185:
URL: https://github.com/apache/nifi/pull/7185#issuecomment-1520059001
Reviewing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org