You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sahil Takiar (Code Review)" <ge...@cloudera.org> on 2016/10/02 02:31:33 UTC
[Impala-ASF-CR] IMPALA-4240: qgen: Add "ParseException line missing )" to Known Errors for Hive
Sahil Takiar has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4587
Change subject: IMPALA-4240: qgen: Add "ParseException line missing )" to Known Errors for Hive
......................................................................
IMPALA-4240: qgen: Add "ParseException line missing )" to Known Errors for Hive
There is a bug in Hive with parenthesis parsing for PARTITION BY clauses. Full details
can be found in https://issues.apache.org/jira/browse/HIVE-14871. Fixing this issue in
Hive isn't trivial, so it should be marked as a "Known Error" in the qgen code.
The exception printed by Hive is of the form:
FAILED: ParseException line ?:? missing ) at '?' near '?'
line ?:? missing EOF at '?' near '?' (state=42000,code=40000)
Testing:
* All unit tests are passing
* Tested against Hive locally
* Tested against Impala via the discrepancy searcher
Change-Id: Iba3ff4c667ad43ab0927fb19da3dd36ba6504058
---
M tests/comparison/discrepancy_searcher.py
1 file changed, 31 insertions(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/4587/1
--
To view, visit http://gerrit.cloudera.org:8080/4587
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba3ff4c667ad43ab0927fb19da3dd36ba6504058
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-4240: qgen: Add "ParseException line missing )" to Known Errors for Hive
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-4240: qgen: Add "ParseException line missing )" to Known Errors for Hive
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4587
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba3ff4c667ad43ab0927fb19da3dd36ba6504058
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4240: qgen: Add "ParseException line missing )" to Known Errors for Hive
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has uploaded a new patch set (#2).
Change subject: IMPALA-4240: qgen: Add "ParseException line missing )" to Known Errors for Hive
......................................................................
IMPALA-4240: qgen: Add "ParseException line missing )" to Known Errors for Hive
There is a bug in Hive with parenthesis parsing for PARTITION BY clauses. Full details
can be found in https://issues.apache.org/jira/browse/HIVE-14871. Fixing this issue in
Hive isn't trivial, so it should be marked as a "Known Error" in the qgen code.
The exception printed by Hive is of the form:
FAILED: ParseException line ?:? missing ) at '?' near '?'
line ?:? missing EOF at '?' near '?' (state=42000,code=40000)
Testing:
* All unit tests are passing
* Tested against Hive locally
* Tested against Impala via the discrepancy searcher
Change-Id: Iba3ff4c667ad43ab0927fb19da3dd36ba6504058
---
M tests/comparison/discrepancy_searcher.py
1 file changed, 30 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/4587/2
--
To view, visit http://gerrit.cloudera.org:8080/4587
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iba3ff4c667ad43ab0927fb19da3dd36ba6504058
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-4240: qgen: Add "ParseException line missing )" to Known Errors for Hive
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has submitted this change and it was merged.
Change subject: IMPALA-4240: qgen: Add "ParseException line missing )" to Known Errors for Hive
......................................................................
IMPALA-4240: qgen: Add "ParseException line missing )" to Known Errors for Hive
There is a bug in Hive with parenthesis parsing for PARTITION BY clauses. Full details
can be found in https://issues.apache.org/jira/browse/HIVE-14871. Fixing this issue in
Hive isn't trivial, so it should be marked as a "Known Error" in the qgen code.
The exception printed by Hive is of the form:
FAILED: ParseException line ?:? missing ) at '?' near '?'
line ?:? missing EOF at '?' near '?' (state=42000,code=40000)
Testing:
* All unit tests are passing
* Tested against Hive locally
* Tested against Impala via the discrepancy searcher
Change-Id: Iba3ff4c667ad43ab0927fb19da3dd36ba6504058
Reviewed-on: http://gerrit.cloudera.org:8080/4587
Reviewed-by: Taras Bobrovytsky <tb...@cloudera.com>
Tested-by: Taras Bobrovytsky <tb...@cloudera.com>
---
M tests/comparison/discrepancy_searcher.py
1 file changed, 30 insertions(+), 21 deletions(-)
Approvals:
Taras Bobrovytsky: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/4587
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba3ff4c667ad43ab0927fb19da3dd36ba6504058
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
[Impala-ASF-CR] IMPALA-4240: qgen: Add "ParseException line missing )" to Known Errors for Hive
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-4240: qgen: Add "ParseException line missing )" to Known Errors for Hive
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4587
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba3ff4c667ad43ab0927fb19da3dd36ba6504058
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: No