You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by tamaashu <gi...@git.apache.org> on 2018/11/08 14:27:25 UTC
[GitHub] zookeeper pull request #698: ZOOKEEPER-3155: Remove Forrest XMLs and their b...
GitHub user tamaashu opened a pull request:
https://github.com/apache/zookeeper/pull/698
ZOOKEEPER-3155: Remove Forrest XMLs and their build process from the …
…project (branch 3.4)
In this commit I've removed the forrest XML files and their result from the repository.
I've also removed the process to generate HTML and PDF files from the forrest files, since it's not needed anymore.
It also effects the test-github-pr.sh and test-patch.sh, since we do have less parameters for them (FORREST_HOME).
Change-Id: I30ecdb181f19eed05d86838b12c75e0c03e33710
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tamaashu/zookeeper ZOOKEEPER-3155-3.4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/698.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #698
----
commit 408b1968051ac582d7f4a81cccd756ac851db36c
Author: Tamas Penzes <ta...@...>
Date: 2018-11-08T14:26:50Z
ZOOKEEPER-3155: Remove Forrest XMLs and their build process from the project (branch 3.4)
In this commit I've removed the forrest XML files and their result from the repository.
I've also removed the process to generate HTML and PDF files from the forrest files, since it's not needed anymore.
It also effects the test-github-pr.sh and test-patch.sh, since we do have less parameters for them (FORREST_HOME).
Change-Id: I30ecdb181f19eed05d86838b12c75e0c03e33710
----
---
[GitHub] zookeeper issue #698: ZOOKEEPER-3155: Remove Forrest XMLs and their build pr...
Posted by tamaashu <gi...@git.apache.org>.
Github user tamaashu commented on the issue:
https://github.com/apache/zookeeper/pull/698
retest this please
---
[GitHub] zookeeper issue #698: ZOOKEEPER-3155: Remove Forrest XMLs and their build pr...
Posted by tamaashu <gi...@git.apache.org>.
Github user tamaashu commented on the issue:
https://github.com/apache/zookeeper/pull/698
> Do we need this on 3.4, I thought we only do bug fixes on 3.4.
For code we only do bug fixes, but the documentation changes (migration to MarkDown) have been backported to branch-3.4 too. It makes more simple to make a (bugfix) release, e.g. you don't have to install Forrest on your build machines anymore to generate the HTMLs.
---
[GitHub] zookeeper issue #698: ZOOKEEPER-3155: Remove Forrest XMLs and their build pr...
Posted by lvfangmin <gi...@git.apache.org>.
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/698
Do we need this on 3.4, I thought we only do bug fixes on 3.4.
---
[GitHub] zookeeper issue #698: ZOOKEEPER-3155: Remove Forrest XMLs and their build pr...
Posted by tamaashu <gi...@git.apache.org>.
Github user tamaashu commented on the issue:
https://github.com/apache/zookeeper/pull/698
retest this please
---
[GitHub] zookeeper pull request #698: ZOOKEEPER-3155: Remove Forrest XMLs and their b...
Posted by tamaashu <gi...@git.apache.org>.
Github user tamaashu closed the pull request at:
https://github.com/apache/zookeeper/pull/698
---
[GitHub] zookeeper issue #698: ZOOKEEPER-3155: Remove Forrest XMLs and their build pr...
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/698
Committed. Thanks @tamaashu !
---