You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "zephyring (via GitHub)" <gi...@apache.org> on 2023/06/13 21:17:39 UTC
[GitHub] [superset] zephyring opened a new pull request, #24394: fix: fixing recent migration file downgrade lineage
zephyring opened a new pull request, #24394:
URL: https://github.com/apache/superset/pull/24394
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
1. recently introduced migration file `drop_access_request` has a downgrade version in future migration file.
2. This PR should fix the order in order to unblock certain people from getting stuck on db migration.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24394: fix: fixing recent migration file downgrade lineage
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24394:
URL: https://github.com/apache/superset/pull/24394#issuecomment-1590051866
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24394?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24394](https://app.codecov.io/gh/apache/superset/pull/24394?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f463576) into [master](https://app.codecov.io/gh/apache/superset/commit/62b4564c947d6efed5d862506b10f3e1e2ba0849?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (62b4564) will **decrease** coverage by `10.82%`.
> The diff coverage is `n/a`.
> :exclamation: Current head f463576 differs from pull request most recent head bab1c52. Consider uploading reports for the commit bab1c52 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24394 +/- ##
===========================================
- Coverage 68.98% 58.16% -10.82%
===========================================
Files 1903 1903
Lines 74126 74126
Branches 8110 8110
===========================================
- Hits 51138 43119 -8019
- Misses 20876 28895 +8019
Partials 2112 2112
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `54.01% <ø> (ø)` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.93% <ø> (ø)` | |
| python | `60.90% <ø> (-22.46%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `54.51% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 302 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24394/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zephyring closed pull request #24394: fix: fixing recent migration file downgrade lineage
Posted by "zephyring (via GitHub)" <gi...@apache.org>.
zephyring closed pull request #24394: fix: fixing recent migration file downgrade lineage
URL: https://github.com/apache/superset/pull/24394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org