You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bridges-dev@portals.apache.org by "David Sean Taylor (JIRA)" <br...@portals.apache.org> on 2006/12/22 23:57:26 UTC

[jira] Assigned: (PB-53) The method setDefaultView() sets the PortletSession attribute with a null value.

     [ http://issues.apache.org/jira/browse/PB-53?page=all ]

David Sean Taylor reassigned PB-53:
-----------------------------------

    Assignee: David Sean Taylor

> The method setDefaultView() sets the PortletSession attribute with a null value.
> --------------------------------------------------------------------------------
>
>                 Key: PB-53
>                 URL: http://issues.apache.org/jira/browse/PB-53
>             Project: Portals Bridges
>          Issue Type: Bug
>          Components: jsf
>    Affects Versions: 1.0
>         Environment: Sun JSF Reference Implementation version 1.2 (jsf-impl.jar)
> Websphere portlet container version 6.1.0
> Apache MyFaces JSF portal bridge version 1.0 (portals-bridges-jsf-1.0.jar)
>            Reporter: Matthew Bruzek
>         Assigned To: David Sean Taylor
>
> The method:  org.apache.portals.bridges.jsf.FacesPortlet.setDefaultView(FacesContext, String, String) contains an else branch that is entered when the viewRoot value is null (line 589).  
> This else branch creates a new viewRoot, a new view id, and sets both on the facesContext object.  The code then creates a view root key and calls portal session set attribute with this key using the null viewRoot value, instead of the viewRoot object that was just created.  The portlet session attribute map will contain a valid viewRoot key, but a null viewRoot value.  This appears to be an error, because the viewRoot is always going to be null when this branch of code is entered.
> I propose that the method call (on line 594 of FacesPortlet) should look like this:
> portletRequest.getPortletSession().setAttribute(createViewRootKey(facesContext, view, viewId), facesContext.getViewRoot() );
> This will store the newly created viewRoot in the portlet session where it can be retrieved.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org