[GitHub] [pinot] ankitsultana commented on a diff in pull request #10487: Fix Bottleneck for Server Bootstrap by Making maxConnsPerRoute Configurable

["ankitsultana (via GitHub)" <gi...@apache.org>]

ankitsultana commented on code in PR #10487:
URL: https://github.com/apache/pinot/pull/10487#discussion_r1155166118


##########
pinot-common/src/main/java/org/apache/pinot/common/utils/http/HttpClient.java:
##########
@@ -86,22 +87,23 @@ public class HttpClient implements AutoCloseable {
   private final CloseableHttpClient _httpClient;
 
   public HttpClient() {
-    this(null);
+    this(HttpClientConfig.DEFAULT_HTTP_CLIENT_CONFIG, null);
   }
 
-  public HttpClient(@Nullable SSLContext sslContext) {
+  public HttpClient(HttpClientConfig httpClientConfig, @Nullable SSLContext sslContext) {

Review Comment:
   How so? Is anyone extending this Class and using their own HttpClient implementations?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org