[GitHub] [skywalking-go] mrproliu commented on a diff in pull request #27: Support adapt Log frameworks

["mrproliu (via GitHub)" <gi...@apache.org>]

mrproliu commented on code in PR #27:
URL: https://github.com/apache/skywalking-go/pull/27#discussion_r1188638488


##########
docs/en/advanced-features/logging-setup.md:
##########
@@ -1,3 +1,42 @@
 # Logging Setup 
 
-Currently, this part has not been done yet.
\ No newline at end of file
+Logging Setup is used to integrate the Go Agent with the logging system in the current service. 
+It currently supports the recognition of `Logrus` and `Zap` frameworks. If neither of these frameworks is present, it would output logs using `Std Error`.
+
+You can learn about the configuration details through the "log" configuration item in the [default settings](../../../tools/go-agent/config/agent.default.yaml).
+
+## Agent with Logging system
+
+The integration of the Agent with logs can be divided into the following:
+
+1. **Integrating Agent logs into the Service**: Integrating the logs from the Agent into the framework used by the service.
+2. **Integrating Tracing information into the Service**: Integrating the information from Tracing into the service logs.
+
+### Agent logs into the Service
+
+Agent logs output the current running status of the Agent system, most of which are execution exceptions. 
+For example, communication anomalies between the Agent and the backend service, plugin execution exceptions, etc.
+
+Integrating Agent logs into the service's logging system can effectively help users quickly troubleshoot whether there are issues with the current Agent execution.
+
+### Tracing information into the Service
+
+The Agent would also enhance the existing logging system. 
+When the service outputs log, if the current goroutine contains Tracing data, it would be outputted together with the current logs. 

Review Comment:
   Nope. For now, the gRPC will keep tracing if the connection is closed. I could create other PR for this. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org