You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "tang-hi (via GitHub)" <gi...@apache.org> on 2023/05/16 02:25:44 UTC

[GitHub] [lucene] tang-hi opened a new pull request, #12298: move max recursion from Operations.java to AutomatonTestUtil.java

tang-hi opened a new pull request, #12298:
URL: https://github.com/apache/lucene/pull/12298

   ### Description
   move max recursion from Operations.java to AutomatonTestUtil.java according to @rmuir 's comment in #12286 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] rmuir commented on pull request #12298: move max recursion from Operations.java to AutomatonTestUtil.java

Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir commented on PR #12298:
URL: https://github.com/apache/lucene/pull/12298#issuecomment-1549465353

   The limit can only be removed in `main` branch as there are still some recursive algorithms in `branch_9x`. More invasive/heavier automaton changes have happened in 10.x, I think it is ok, we are still moving forwards.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] tang-hi commented on pull request #12298: move max recursion from Operations.java to AutomatonTestUtil.java

Posted by "tang-hi (via GitHub)" <gi...@apache.org>.
tang-hi commented on PR #12298:
URL: https://github.com/apache/lucene/pull/12298#issuecomment-1549551695

   thanks @rmuir 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] rmuir merged pull request #12298: move max recursion from Operations.java to AutomatonTestUtil.java

Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir merged PR #12298:
URL: https://github.com/apache/lucene/pull/12298


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] mikemccand commented on pull request #12298: move max recursion from Operations.java to AutomatonTestUtil.java

Posted by "mikemccand (via GitHub)" <gi...@apache.org>.
mikemccand commented on PR #12298:
URL: https://github.com/apache/lucene/pull/12298#issuecomment-1549796778

   Thank you @tang-hi!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org