You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/12 09:52:10 UTC

[GitHub] [flink] Peng-Lei commented on a diff in pull request #20193: [WIP][FLINK-28433][connector/jdbc]Add mariadb jdbc connection validation

Peng-Lei commented on code in PR #20193:
URL: https://github.com/apache/flink/pull/20193#discussion_r918776111


##########
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/mysql/MySqlDialectFactory.java:
##########
@@ -27,7 +27,7 @@
 public class MySqlDialectFactory implements JdbcDialectFactory {
     @Override
     public boolean acceptsURL(String url) {
-        return url.startsWith("jdbc:mysql:");
+        return (url.startsWith("jdbc:mysql:") || url.startsWith("jdbc:mariadb:"));

Review Comment:
   I think no need change here after we add `MariaDBDialectFactory`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org